user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3473 from lucasloisp/additional-bool-comparisons

Browse source 
Adds inequality cases to bool comparison (#3438)
This commit is contained in:
Philipp Hansch 2018-12-04 07:26:29 +01:00 • committed by GitHub
commit 68bb900eba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 95 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/ui/bool_comparison.rs
View file

@ -18,4 +18,8 @@ fn main() {
if x == false { "yes" } else { "no" };
if true == x { "yes" } else { "no" };
if false == x { "yes" } else { "no" };
if x != true { "yes" } else { "no" };
if x != false { "yes" } else { "no" };
if true != x { "yes" } else { "no" };
if false != x { "yes" } else { "no" };
}

26
tests/ui/bool_comparison.stderr
View file

@ -24,5 +24,29 @@ error: equality checks against false can be replaced by a negation
20 | if false == x { "yes" } else { "no" };
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
error: aborting due to 4 previous errors
error: inequality checks against true can be replaced by a negation
--> $DIR/bool_comparison.rs:21:8
|
21 | if x != true { "yes" } else { "no" };
| ^^^^^^^^^ help: try simplifying it as shown: `!x`
error: inequality checks against false are unnecessary
--> $DIR/bool_comparison.rs:22:8
|
22 | if x != false { "yes" } else { "no" };
| ^^^^^^^^^^ help: try simplifying it as shown: `x`
error: inequality checks against true can be replaced by a negation
--> $DIR/bool_comparison.rs:23:8
|
23 | if true != x { "yes" } else { "no" };
| ^^^^^^^^^ help: try simplifying it as shown: `!x`
error: inequality checks against false are unnecessary
--> $DIR/bool_comparison.rs:24:8
|
24 | if false != x { "yes" } else { "no" };
| ^^^^^^^^^^ help: try simplifying it as shown: `x`
error: aborting due to 8 previous errors