diff --git a/src/librustdoc/clean.rs b/src/librustdoc/clean.rs index c0c146319cba..586323358c24 100644 --- a/src/librustdoc/clean.rs +++ b/src/librustdoc/clean.rs @@ -25,7 +25,6 @@ use rustc::metadata::csearch; use rustc::metadata::decoder; use std; -use std::hashmap::HashMap; use doctree; use visit_ast; @@ -68,7 +67,7 @@ impl, U> Clean<~[U]> for syntax::opt_vec::OptVec { pub struct Crate { name: ~str, module: Option, - externs: HashMap, + externs: ~[(ast::CrateNum, ExternalCrate)], } impl<'a> Clean for visit_ast::RustdocVisitor<'a> { @@ -76,9 +75,9 @@ impl<'a> Clean for visit_ast::RustdocVisitor<'a> { use syntax::attr::find_crateid; let cx = local_data::get(super::ctxtkey, |x| *x.unwrap()); - let mut externs = HashMap::new(); + let mut externs = ~[]; cx.sess.cstore.iter_crate_data(|n, meta| { - externs.insert(n, meta.clean()); + externs.push((n, meta.clean())); }); Crate { diff --git a/src/librustdoc/html/render.rs b/src/librustdoc/html/render.rs index 5299b31ac7bc..07ea22d42ecb 100644 --- a/src/librustdoc/html/render.rs +++ b/src/librustdoc/html/render.rs @@ -305,7 +305,7 @@ pub fn run(mut krate: clean::Crate, dst: Path) -> io::IoResult<()> { krate = folder.fold_crate(krate); } - for (&n, e) in krate.externs.iter() { + for &(n, ref e) in krate.externs.iter() { cache.extern_locations.insert(n, extern_location(e, &cx.dst)); } diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index 2c4d553a39f6..4194f5e47293 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -344,7 +344,7 @@ fn json_output(krate: clean::Crate, res: ~[plugins::PluginJson], }; let crate_json = match json::from_str(crate_json_str) { Ok(j) => j, - Err(_) => fail!("Rust generated JSON is invalid??") + Err(e) => fail!("Rust generated JSON is invalid: {:?}", e) }; json.insert(~"crate", crate_json); diff --git a/src/test/run-make/rustdoc-json/Makefile b/src/test/run-make/rustdoc-json/Makefile new file mode 100644 index 000000000000..5e6ab4b790ee --- /dev/null +++ b/src/test/run-make/rustdoc-json/Makefile @@ -0,0 +1,4 @@ +-include ../tools.mk +all: + $(RUSTDOC) -w json -o $(TMPDIR)/doc.json foo.rs + $(RUSTDOC) -o $(TMPDIR)/doc $(TMPDIR)/doc.json diff --git a/src/test/run-make/rustdoc-json/foo.rs b/src/test/run-make/rustdoc-json/foo.rs new file mode 100644 index 000000000000..818ec1e5eb79 --- /dev/null +++ b/src/test/run-make/rustdoc-json/foo.rs @@ -0,0 +1,25 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#[crate_id = "foo#0.1"]; + +//! Very docs + +pub mod bar { + + /// So correct + pub mod baz { + /// Much detail + pub fn baz() { } + } + + /// *wow* + pub trait Doge { } +}