user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tidy: Fix a regression in #[test] detection in libcore

Browse source 
`contents` is the whole file rather than a single line.
This commit is contained in:
Vadim Petrochenkov 2019-07-26 01:22:59 +03:00
parent c0df742de8
commit 6a4def0c9d
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/tools/tidy/src/unit_tests.rs
View file

@ -13,14 +13,16 @@ pub fn check(path: &Path, bad: &mut bool) {
&mut |entry, contents| {
let subpath = entry.path();
if let Some("rs") = subpath.extension().and_then(|e| e.to_str()) {
let contents = contents.trim();
if !contents.starts_with("//") && contents.contains("#[test]") {
tidy_error!(
bad,
"`{}` contains `#[test]`; libcore tests must be placed inside \
`src/libcore/tests/`",
subpath.display()
);
for line in contents.lines() {
let line = line.trim();
if !line.starts_with("//") && line.contains("#[test]") {
tidy_error!(
bad,
"`{}` contains `#[test]`; libcore tests must be placed inside \
`src/libcore/tests/`",
subpath.display()
);
}
}
}
},