std: Don't always create stdin for children

For example if `Command::output` or `Command::status` is used then stdin is just
immediately closed. Add an option for this so as an optimization we can avoid
creating pipes entirely.

This should help reduce the number of active file descriptors when spawning
processes on Unix and the number of active handles on Windows.
This commit is contained in:
Alex Crichton 2016-02-12 10:28:03 -08:00
parent d46c99abe8
commit 6afa32a250
3 changed files with 16 additions and 10 deletions

View file

@ -216,7 +216,7 @@ impl Command {
self.stderr = Some(stderr);
}
pub fn spawn(&mut self, default: Stdio)
pub fn spawn(&mut self, default: Stdio, needs_stdin: bool)
-> io::Result<(Process, StdioPipes)> {
const CLOEXEC_MSG_FOOTER: &'static [u8] = b"NOEX";
@ -225,7 +225,7 @@ impl Command {
"nul byte found in provided data"));
}
let (ours, theirs) = try!(self.setup_io(default));
let (ours, theirs) = try!(self.setup_io(default, needs_stdin));
let (input, output) = try!(sys::pipe::anon_pipe());
let pid = unsafe {
@ -298,7 +298,7 @@ impl Command {
"nul byte found in provided data")
}
match self.setup_io(default) {
match self.setup_io(default, true) {
Ok((_, theirs)) => unsafe { self.do_exec(theirs) },
Err(e) => e,
}
@ -408,8 +408,11 @@ impl Command {
}
fn setup_io(&self, default: Stdio) -> io::Result<(StdioPipes, ChildPipes)> {
let stdin = self.stdin.as_ref().unwrap_or(&default);
fn setup_io(&self, default: Stdio, needs_stdin: bool)
-> io::Result<(StdioPipes, ChildPipes)> {
let null = Stdio::Null;
let default_stdin = if needs_stdin {&default} else {&null};
let stdin = self.stdin.as_ref().unwrap_or(default_stdin);
let stdout = self.stdout.as_ref().unwrap_or(&default);
let stderr = self.stderr.as_ref().unwrap_or(&default);
let (their_stdin, our_stdin) = try!(stdin.to_child_stdio(true));