user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed suggestion in macro invocations

Browse source
This commit is contained in:
Bastian Kersting 2021-02-06 20:05:51 +01:00
parent f1c15840a2
commit 6b4789d7cf
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/semicolon_if_nothing_returned.rs
View file

@ -49,12 +49,12 @@ impl LateLintPass<'_> for SemicolonIfNothingReturned {
return;
}
let sugg = sugg::Sugg::hir(cx, &expr, "..");
let sugg = sugg::Sugg::hir_with_macro_callsite(cx, &expr, "..");
let suggestion = format!("{0};", sugg);
span_lint_and_sugg(
cx,
SEMICOLON_IF_NOTHING_RETURNED,
expr.span,
expr.span.source_callsite(),
"consider adding a `;` to the last statement for consistent formatting",
"add a `;` here",
suggestion,

3
tests/ui/semicolon_if_nothing_returned.stderr
View file

@ -2,10 +2,9 @@ error: consider adding a `;` to the last statement for consistent formatting
--> $DIR/semicolon_if_nothing_returned.rs:8:5
|
LL | println!("Hello")
| ^^^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^^^ help: add a `;` here: `println!("Hello");`
|
= note: `-D clippy::semicolon-if-nothing-returned` implied by `-D warnings`
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: consider adding a `;` to the last statement for consistent formatting
--> $DIR/semicolon_if_nothing_returned.rs:12:5