From f2f0ac9fe051af0a52408984c39f0a97fd11dbf3 Mon Sep 17 00:00:00 2001 From: Erick Tryzelaar Date: Thu, 23 Aug 2012 18:25:29 -0700 Subject: [PATCH 1/2] libstd: serialization should use &strs. --- src/libstd/ebml.rs | 10 +++++----- src/libstd/prettyprint.rs | 6 +++--- src/libstd/serialization.rs | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libstd/ebml.rs b/src/libstd/ebml.rs index 04efe4aa7457..11cd17515dac 100644 --- a/src/libstd/ebml.rs +++ b/src/libstd/ebml.rs @@ -320,7 +320,7 @@ enum ebml_serializer_tag { trait serializer_priv { fn _emit_tagged_uint(t: ebml_serializer_tag, v: uint); - fn _emit_label(label: ~str); + fn _emit_label(label: &str); } impl ebml::writer: serializer_priv { @@ -330,7 +330,7 @@ impl ebml::writer: serializer_priv { self.wr_tagged_u32(t as uint, v as u32); } - fn _emit_label(label: ~str) { + fn _emit_label(label: &str) { // There are various strings that we have access to, such as // the name of a record field, which do not actually appear in // the serialized EBML (normally). This is just for @@ -365,11 +365,11 @@ impl ebml::writer: serialization::serializer { fn emit_str(v: &str) { self.wr_tagged_str(es_str as uint, v) } - fn emit_enum(name: ~str, f: fn()) { + fn emit_enum(name: &str, f: fn()) { self._emit_label(name); self.wr_tag(es_enum as uint, f) } - fn emit_enum_variant(_v_name: ~str, v_id: uint, _cnt: uint, f: fn()) { + fn emit_enum_variant(_v_name: &str, v_id: uint, _cnt: uint, f: fn()) { self._emit_tagged_uint(es_enum_vid, v_id); self.wr_tag(es_enum_body as uint, f) } @@ -389,7 +389,7 @@ impl ebml::writer: serialization::serializer { fn emit_box(f: fn()) { f() } fn emit_uniq(f: fn()) { f() } fn emit_rec(f: fn()) { f() } - fn emit_rec_field(f_name: ~str, _f_idx: uint, f: fn()) { + fn emit_rec_field(f_name: &str, _f_idx: uint, f: fn()) { self._emit_label(f_name); f() } diff --git a/src/libstd/prettyprint.rs b/src/libstd/prettyprint.rs index 4e21da29fd77..259bb4eb612e 100644 --- a/src/libstd/prettyprint.rs +++ b/src/libstd/prettyprint.rs @@ -67,11 +67,11 @@ impl Writer: serializer { self.write_str(fmt!("%?", v)); } - fn emit_enum(_name: ~str, f: fn()) { + fn emit_enum(_name: &str, f: fn()) { f(); } - fn emit_enum_variant(v_name: ~str, _v_id: uint, sz: uint, f: fn()) { + fn emit_enum_variant(v_name: &str, _v_id: uint, sz: uint, f: fn()) { self.write_str(v_name); if sz > 0u { self.write_str(~"("); } f(); @@ -110,7 +110,7 @@ impl Writer: serializer { self.write_str(~"}"); } - fn emit_rec_field(f_name: ~str, f_idx: uint, f: fn()) { + fn emit_rec_field(f_name: &str, f_idx: uint, f: fn()) { if f_idx > 0u { self.write_str(~", "); } self.write_str(f_name); self.write_str(~": "); diff --git a/src/libstd/serialization.rs b/src/libstd/serialization.rs index da99cb7882ec..b41d9a6dbec3 100644 --- a/src/libstd/serialization.rs +++ b/src/libstd/serialization.rs @@ -26,15 +26,15 @@ trait serializer { fn emit_str(v: &str); // Compound types: - fn emit_enum(name: ~str, f: fn()); - fn emit_enum_variant(v_name: ~str, v_id: uint, sz: uint, f: fn()); + fn emit_enum(name: &str, f: fn()); + fn emit_enum_variant(v_name: &str, v_id: uint, sz: uint, f: fn()); fn emit_enum_variant_arg(idx: uint, f: fn()); fn emit_vec(len: uint, f: fn()); fn emit_vec_elt(idx: uint, f: fn()); fn emit_box(f: fn()); fn emit_uniq(f: fn()); fn emit_rec(f: fn()); - fn emit_rec_field(f_name: ~str, f_idx: uint, f: fn()); + fn emit_rec_field(f_name: &str, f_idx: uint, f: fn()); fn emit_tup(sz: uint, f: fn()); fn emit_tup_elt(idx: uint, f: fn()); } From dab3339971d91946fd99c9613dc7d51a9d1fb922 Mon Sep 17 00:00:00 2001 From: Erick Tryzelaar Date: Fri, 24 Aug 2012 18:24:46 -0700 Subject: [PATCH 2/2] libstd: Suppress warning about unused variable in net_tcp. --- src/libstd/net_tcp.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libstd/net_tcp.rs b/src/libstd/net_tcp.rs index 170823eb79dc..cafe0f38a95d 100644 --- a/src/libstd/net_tcp.rs +++ b/src/libstd/net_tcp.rs @@ -153,7 +153,7 @@ fn connect(-input_ip: ip::ip_addr, port: uint, 0i32 => { log(debug, ~"tcp_init successful"); match input_ip { - ipv4 => { + _ipv4 => { log(debug, ~"dealing w/ ipv4 connection.."); let connect_req_ptr = ptr::addr_of((*socket_data_ptr).connect_req);