user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rustup to *1.10.0-nightly (764ef92ae 2016-05-19)*

Browse source
This commit is contained in:
mcarton 2016-05-20 19:18:32 +02:00
parent 2a5416d662
commit 6dd608e53e
No known key found for this signature in database
GPG key ID: 5E427C794CBA45E8
4 changed files with 15 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/vec.rs
View file

@ -38,17 +38,19 @@ impl LateLintPass for UselessVec {
let TypeVariants::TySlice(..) = ty.ty.sty,
let ExprAddrOf(_, ref addressee) = expr.node,
], {
check_vec_macro(cx, expr, addressee);
check_vec_macro(cx, addressee, expr.span);
}}
// search for `for _ in vec![…]`
if let Some((_, arg, _)) = recover_for_loop(expr) {
check_vec_macro(cx, arg, arg);
// report the error around the `vec!` not inside `<std macros>:`
let span = cx.sess().codemap().source_callsite(arg.span);
check_vec_macro(cx, arg, span);
}
}
}
fn check_vec_macro(cx: &LateContext, expr: &Expr, vec: &Expr) {
fn check_vec_macro(cx: &LateContext, vec: &Expr, span: Span) {
if let Some(vec_args) = unexpand_vec(cx, vec) {
let snippet = match vec_args {
VecArgs::Repeat(elem, len) => {
@ -69,8 +71,8 @@ fn check_vec_macro(cx: &LateContext, expr: &Expr, vec: &Expr) {
}
};
span_lint_and_then(cx, USELESS_VEC, expr.span, "useless use of `vec!`", |db| {
db.span_suggestion(expr.span, "you can use a slice directly", snippet);
span_lint_and_then(cx, USELESS_VEC, span, "useless use of `vec!`", |db| {
db.span_suggestion(span, "you can use a slice directly", snippet);
});
}
}