user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #84552 - GuillaumeGomez:open-impl-blocks-by-default, r=jsha

Browse source 
Open impl blocks by default

Fixes #84558.
Part of #84422.

As you can see on https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html, impl blocks are currently not open by default whereas they should.

I also realized that a test was outdated so I removed it and opened #84550 because it seems like the rustdoc-gui test suite isn't run on CI...

cc `@jyn514`
r? `@jsha`
This commit is contained in:
bors 2021-04-27 01:58:29 +00:00
commit 6eb956fcbb
5 changed files with 27 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/librustdoc/html/render/mod.rs
View file

@ -1305,7 +1305,7 @@ fn render_impl(
if let Some(use_absolute) = use_absolute {
write!(
w,
"<details class=\"rustdoc-toggle implementors-toggle\">\
"<details class=\"rustdoc-toggle implementors-toggle\" open>\
<summary>\
<h3 id=\"{}\" class=\"impl\"{}>\
<code class=\"in-band\">",
@ -1334,7 +1334,7 @@ fn render_impl(
} else {
write!(
w,
"<details class=\"rustdoc-toggle implementors-toggle\">\
"<details class=\"rustdoc-toggle implementors-toggle\" open>\
<summary>\
<h3 id=\"{}\" class=\"impl\"{}>\
<code class=\"in-band\">{}</code>",

6
src/librustdoc/html/static/main.js
View file

@ -480,6 +480,8 @@ function hideThemeButtonState() {
}
// Open all ancestor <details> to make this element visible.
openParentDetails(h3.parentNode);
} else {
openParentDetails(elem.parentNode);
}
}
}
@ -1412,9 +1414,9 @@ function hideThemeButtonState() {
// errors in mobile browsers).
if (e.tagName === "H2" || e.tagName === "H3") {
var nextTagName = e.nextElementSibling.tagName;
if (nextTagName == "H2" || nextTagName == "H3") {
if (nextTagName === "H2" || nextTagName === "H3") {
e.nextElementSibling.style.display = "flex";
} else {
} else if (nextTagName !== "DETAILS") {
e.nextElementSibling.style.display = "block";
}
}