From 6ed6791df49d8f33a3f49662e7baf559ef59e604 Mon Sep 17 00:00:00 2001
From: Eric Holk <eholk@mozilla.com>
Date: Thu, 16 Jun 2011 12:18:54 -0700
Subject: [PATCH] Removing dead upcall_join. Closes #509.

---
 src/comp/back/upcall.rs |  2 --
 src/rt/rust_upcall.cpp  | 21 ---------------------
 src/rt/rustrt.def.in    |  1 -
 3 files changed, 24 deletions(-)

diff --git a/src/comp/back/upcall.rs b/src/comp/back/upcall.rs
index 604ca8a5b587..7cb859a8fa3f 100644
--- a/src/comp/back/upcall.rs
+++ b/src/comp/back/upcall.rs
@@ -40,7 +40,6 @@ type upcalls =
         ValueRef clone_chan,
         ValueRef _yield,
         ValueRef sleep,
-        ValueRef _join,
         ValueRef send,
         ValueRef recv,
         ValueRef _fail,
@@ -91,7 +90,6 @@ fn declare_upcalls(type_names tn, ModuleRef llmod) -> @upcalls {
                           T_opaque_chan_ptr()),
              _yield=dv("yield", empty_vec),
              sleep=dv("sleep", [T_size_t()]),
-             _join=dv("join", [T_taskptr(tn)]),
              send=dv("send", [T_opaque_chan_ptr(), T_ptr(T_i8())]),
              recv=dv("recv", [T_ptr(T_ptr(T_i8())), T_opaque_port_ptr()]),
              _fail=dv("fail", [T_ptr(T_i8()), T_ptr(T_i8()), T_size_t()]),
diff --git a/src/rt/rust_upcall.cpp b/src/rt/rust_upcall.cpp
index bfb72ffd648d..1a0d4f8c0b05 100644
--- a/src/rt/rust_upcall.cpp
+++ b/src/rt/rust_upcall.cpp
@@ -195,27 +195,6 @@ upcall_sleep(rust_task *task, size_t time_in_us) {
     task->yield(2, time_in_us);
 }
 
-extern "C" CDECL void
-upcall_join(rust_task *task, maybe_proxy<rust_task> *target) {
-    LOG_UPCALL_ENTRY(task);
-
-    if (target->is_proxy()) {
-        rust_handle<rust_task> *task_handle = target->as_proxy()->handle();
-        notify_message::send(notify_message::JOIN, "join",
-                             task->get_handle(), task_handle);
-        task->block(task_handle, "joining remote task");
-        task->yield(2);
-    } else {
-        rust_task *target_task = target->referent();
-        // If the other task is already dying, we don't have to wait for it.
-        if (target_task->dead() == false) {
-            target_task->tasks_waiting_to_join.push(task);
-            task->block(target_task, "joining local task");
-            task->yield(2);
-        }
-    }
-}
-
 /**
  * Buffers a chunk of data in the specified channel.
  *
diff --git a/src/rt/rustrt.def.in b/src/rt/rustrt.def.in
index 9fb1b45287e7..ef0d5878ad8b 100644
--- a/src/rt/rustrt.def.in
+++ b/src/rt/rustrt.def.in
@@ -51,7 +51,6 @@ upcall_get_type_desc
 upcall_grow_task
 upcall_ivec_resize
 upcall_ivec_spill
-upcall_join
 upcall_kill
 upcall_log_double
 upcall_log_float