user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #6403 - camsteffen:similar-names-underscore, r=Manishearth

Browse source 
Similar names ignore underscore prefixed names

changelog: Ignore underscore-prefixed names for similar_names

IMO, this lint is not very helpful for underscore-prefixed variables. Usually they are unused or are just there to ignore part of a destructuring.
This commit is contained in:
bors 2021-01-22 23:44:12 +00:00
commit 70386ff352
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/non_expressive_names.rs
View file

@ -199,6 +199,10 @@ impl<'a, 'tcx, 'b> SimilarNamesNameVisitor<'a, 'tcx, 'b> {
);
return;
}
if interned_name.starts_with('_') {
// these bindings are typically unused or represent an ignored portion of a destructuring pattern
return;
}
let count = interned_name.chars().count();
if count < 3 {
if count == 1 {