user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix implicit_return suggestion for async functions

Browse source
This commit is contained in:
Jason Newcomb 2021-04-02 17:53:14 -04:00
parent 22f8c13cf5
commit 74cf5f2fc6
No known key found for this signature in database
GPG key ID: DA59E8643A37ED06
5 changed files with 81 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

11
clippy_lints/src/implicit_return.rs
View file

@ -1,5 +1,6 @@
use clippy_utils::{
diagnostics::span_lint_and_sugg,
get_async_fn_body, is_async_fn,
source::{snippet_with_applicability, snippet_with_context, walk_span_to_context},
visitors::visit_break_exprs,
};
@ -219,6 +220,14 @@ impl<'tcx> LateLintPass<'tcx> for ImplicitReturn {
return;
}
lint_implicit_returns(cx, &body.value, body.value.span.ctxt(), None);
let expr = if is_async_fn(kind) {
match get_async_fn_body(cx.tcx, body) {
Some(e) => e,
None => return,
}
} else {
&body.value
};
lint_implicit_returns(cx, expr, expr.span.ctxt(), None);
}
}