From 74eb44834cc12ce51396d94e98b04fdd0ad9bb64 Mon Sep 17 00:00:00 2001
From: flip1995 <philipp.krones@embecosm.com>
Date: Fri, 5 Mar 2021 14:06:43 +0100
Subject: [PATCH] Extract directory creation into its own function

---
 clippy_dev/src/lintcheck.rs | 39 +++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 15 deletions(-)

diff --git a/clippy_dev/src/lintcheck.rs b/clippy_dev/src/lintcheck.rs
index 81b86481f570..f01f14eb458f 100644
--- a/clippy_dev/src/lintcheck.rs
+++ b/clippy_dev/src/lintcheck.rs
@@ -115,21 +115,7 @@ impl CrateSource {
                 // url to download the crate from crates.io
                 let url = format!("https://crates.io/api/v1/crates/{}/{}/download", name, version);
                 println!("Downloading and extracting {} {} from {}", name, version, url);
-                std::fs::create_dir("target/lintcheck/").unwrap_or_else(|err| {
-                    if err.kind() != ErrorKind::AlreadyExists {
-                        panic!("cannot create lintcheck target dir");
-                    }
-                });
-                std::fs::create_dir(&krate_download_dir).unwrap_or_else(|err| {
-                    if err.kind() != ErrorKind::AlreadyExists {
-                        panic!("cannot create crate download dir");
-                    }
-                });
-                std::fs::create_dir(&extract_dir).unwrap_or_else(|err| {
-                    if err.kind() != ErrorKind::AlreadyExists {
-                        panic!("cannot create crate extraction dir");
-                    }
-                });
+                create_dirs(&krate_download_dir, &extract_dir);
 
                 let krate_file_path = krate_download_dir.join(format!("{}-{}.crate.tar.gz", name, version));
                 // don't download/extract if we already have done so
@@ -750,6 +736,29 @@ fn print_stats(old_stats: HashMap<String, usize>, new_stats: HashMap<&String, us
         });
 }
 
+/// Create necessary directories to run the lintcheck tool.
+///
+/// # Panics
+///
+/// This function panics if creating one of the dirs fails.
+fn create_dirs(krate_download_dir: &Path, extract_dir: &Path) {
+    std::fs::create_dir("target/lintcheck/").unwrap_or_else(|err| {
+        if err.kind() != ErrorKind::AlreadyExists {
+            panic!("cannot create lintcheck target dir");
+        }
+    });
+    std::fs::create_dir(&krate_download_dir).unwrap_or_else(|err| {
+        if err.kind() != ErrorKind::AlreadyExists {
+            panic!("cannot create crate download dir");
+        }
+    });
+    std::fs::create_dir(&extract_dir).unwrap_or_else(|err| {
+        if err.kind() != ErrorKind::AlreadyExists {
+            panic!("cannot create crate extraction dir");
+        }
+    });
+}
+
 #[test]
 fn lintcheck_test() {
     let args = [