From 7708abbbef679d208041bff57aa9ad50e9419895 Mon Sep 17 00:00:00 2001
From: jumbatm <fungjys@gmail.com>
Date: Sun, 16 Aug 2020 17:14:09 +1000
Subject: [PATCH] Avoid double hashset lookup.

Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
---
 src/librustc_lint/builtin.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs
index 781ebb671675..8625dc096d50 100644
--- a/src/librustc_lint/builtin.rs
+++ b/src/librustc_lint/builtin.rs
@@ -2161,12 +2161,11 @@ impl ClashingExternDeclarations {
             ckind: CItemKind,
         ) -> bool {
             debug!("structurally_same_type_impl(cx, a = {:?}, b = {:?})", a, b);
-            if seen_types.contains(&(a, b)) {
+            if !seen_types.insert((a, b)) {
                 // We've encountered a cycle. There's no point going any further -- the types are
                 // structurally the same.
                 return true;
             }
-            seen_types.insert((a, b));
             let tcx = cx.tcx;
             if a == b || rustc_middle::ty::TyS::same_type(a, b) {
                 // All nominally-same types are structurally same, too.