user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove #[fixed_stack_segment] and #[rust_stack]

Browse source 
These two attributes are no longer useful now that Rust has decided to leave
segmented stacks behind. It is assumed that the rust task's stack is always
large enough to make an FFI call (due to the stack being very large).

There's always the case of stack overflow, however, to consider. This does not
change the behavior of stack overflow in Rust. This is still normally triggered
by the __morestack function and aborts the whole process.

C stack overflow will continue to corrupt the stack, however (as it did before
this commit as well). The future improvement of a guard page at the end of every
rust stack is still unimplemented and is intended to be the mechanism through
which we attempt to detect C stack overflow.

Closes #8822
Closes #10155
This commit is contained in:
Alex Crichton 2013-11-06 15:16:04 -08:00
parent 4059b5c4b3
commit 7755ffd013
111 changed files with 259 additions and 1045 deletions
Download patch file Download diff file Expand all files Collapse all files

78
src/libsyntax/ext/expand.rs
View file

@ -959,84 +959,6 @@ pub fn std_macros() -> @str {
pub static $name: ::std::local_data::Key<$ty> = &::std::local_data::Key;
)
)
/// externfn! declares a wrapper for an external function.
/// It is intended to be used like:
///
/// externfn!(#[nolink]
/// fn memcmp(cx: *u8, ct: *u8, n: u32) -> u32)
///
/// Due to limitations in the macro parser, this pattern must be
/// implemented with 4 distinct patterns (with attrs / without
/// attrs CROSS with args / without ARGS).
///
/// Also, this macro grammar allows for any number of return types
/// because I couldn't figure out the syntax to specify at most one.
macro_rules! externfn(
(fn $name:ident () $(-> $ret_ty:ty),*) => (
pub unsafe fn $name() $(-> $ret_ty),* {
// Note: to avoid obscure bug in macros, keep these
// attributes *internal* to the fn
#[fixed_stack_segment];
#[inline(never)];
#[allow(missing_doc)];
return $name();
extern {
fn $name() $(-> $ret_ty),*;
}
}
);
(fn $name:ident ($($arg_name:ident : $arg_ty:ty),*) $(-> $ret_ty:ty),*) => (
pub unsafe fn $name($($arg_name : $arg_ty),*) $(-> $ret_ty),* {
// Note: to avoid obscure bug in macros, keep these
// attributes *internal* to the fn
#[fixed_stack_segment];
#[inline(never)];
#[allow(missing_doc)];
return $name($($arg_name),*);
extern {
fn $name($($arg_name : $arg_ty),*) $(-> $ret_ty),*;
}
}
);
($($attrs:attr)* fn $name:ident () $(-> $ret_ty:ty),*) => (
pub unsafe fn $name() $(-> $ret_ty),* {
// Note: to avoid obscure bug in macros, keep these
// attributes *internal* to the fn
#[fixed_stack_segment];
#[inline(never)];
#[allow(missing_doc)];
return $name();
$($attrs)*
extern {
fn $name() $(-> $ret_ty),*;
}
}
);
($($attrs:attr)* fn $name:ident ($($arg_name:ident : $arg_ty:ty),*) $(-> $ret_ty:ty),*) => (
pub unsafe fn $name($($arg_name : $arg_ty),*) $(-> $ret_ty),* {
// Note: to avoid obscure bug in macros, keep these
// attributes *internal* to the fn
#[fixed_stack_segment];
#[inline(never)];
#[allow(missing_doc)];
return $name($($arg_name),*);
$($attrs)*
extern {
fn $name($($arg_name : $arg_ty),*) $(-> $ret_ty),*;
}
}
)
)
}"#
}