user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix suggestions that need parens

Browse source
This commit is contained in:
ThibsG 2021-01-31 21:43:35 +01:00
parent 5db215bca8
commit 7825bf36d8
3 changed files with 27 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/ui/from_iter_instead_of_collect.rs
View file

@ -1,6 +1,6 @@
#![warn(clippy::from_iter_instead_of_collect)]
use std::collections::HashMap;
use std::collections::{HashMap, VecDeque};
use std::iter::FromIterator;
fn main() {
@ -10,4 +10,10 @@ fn main() {
HashMap::<usize, &i8>::from_iter(vec![5, 5, 5, 5].iter().enumerate());
Vec::from_iter(vec![42u32]);
let a = vec![0, 1, 2];
assert_eq!(a, Vec::from_iter(0..3));
let mut b = VecDeque::from_iter(0..3);
b.push_back(4);
}

14
tests/ui/from_iter_instead_of_collect.stderr
View file

@ -12,5 +12,17 @@ error: usage of `FromIterator::from_iter`
LL | HashMap::<usize, &i8>::from_iter(vec![5, 5, 5, 5].iter().enumerate());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `.collect()` instead of `::from_iter()`: `vec![5, 5, 5, 5].iter().enumerate().collect()`
error: aborting due to 2 previous errors
error: usage of `FromIterator::from_iter`
--> $DIR/from_iter_instead_of_collect.rs:15:19
|
LL | assert_eq!(a, Vec::from_iter(0..3));
| ^^^^^^^^^^^^^^^^^^^^ help: use `.collect()` instead of `::from_iter()`: `(0..3).collect::<std::vec::Vec<i32>>()`
error: usage of `FromIterator::from_iter`
--> $DIR/from_iter_instead_of_collect.rs:17:17
|
LL | let mut b = VecDeque::from_iter(0..3);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `.collect()` instead of `::from_iter()`: `(0..3).collect::<std::collections::VecDeque<i32>>()`
error: aborting due to 4 previous errors