user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply collapsible_if to Clippy itself

Browse source 
Since Clippy uses the `let_chains` feature, there are many occasions to
collapse `if` and `if let` statements.
This commit is contained in:
Samuel Tardieu 2025-03-26 20:38:58 +01:00
parent cd70152470
commit 79c69112dc
135 changed files with 1870 additions and 1913 deletions
Download patch file Download diff file Expand all files Collapse all files

13
clippy_lints/src/missing_inline.rs
View file

@ -160,12 +160,13 @@ impl<'tcx> LateLintPass<'tcx> for MissingInline {
AssocItemContainer::Impl => cx.tcx.impl_trait_ref(container_id).map(|t| t.skip_binder().def_id),
};
if let Some(trait_def_id) = trait_def_id {
if trait_def_id.is_local() && !cx.effective_visibilities.is_exported(impl_item.owner_id.def_id) {
// If a trait is being implemented for an item, and the
// trait is not exported, we don't need #[inline]
return;
}
if let Some(trait_def_id) = trait_def_id
&& trait_def_id.is_local()
&& !cx.effective_visibilities.is_exported(impl_item.owner_id.def_id)
{
// If a trait is being implemented for an item, and the
// trait is not exported, we don't need #[inline]
return;
}
let attrs = cx.tcx.hir_attrs(impl_item.hir_id());