user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lint-docs: apply considerable clippy suggestions

Browse source 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
This commit is contained in:
onur-ozkan 2024-06-06 21:02:23 +03:00
parent 5aa3fbce61
commit 80d96dffae
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/tools/lint-docs/src/groups.rs
View file

@ -121,13 +121,13 @@ impl<'a> LintExtractor<'a> {
};
to_link.extend(group_lints);
let brackets: Vec<_> = group_lints.iter().map(|l| format!("[{}]", l)).collect();
write!(result, "| {} | {} | {} |\n", group_name, description, brackets.join(", "))
writeln!(result, "| {} | {} | {} |", group_name, description, brackets.join(", "))
.unwrap();
}
result.push('\n');
result.push_str("[warn-by-default]: listing/warn-by-default.md\n");
for lint_name in to_link {
let lint_def = match lints.iter().find(|l| l.name == lint_name.replace("-", "_")) {
let lint_def = match lints.iter().find(|l| l.name == lint_name.replace('-', "_")) {
Some(def) => def,
None => {
let msg = format!(
@ -144,9 +144,9 @@ impl<'a> LintExtractor<'a> {
}
}
};
write!(
writeln!(
result,
"[{}]: listing/{}#{}\n",
"[{}]: listing/{}#{}",
lint_name,
lint_def.level.doc_filename(),
lint_name

12
src/tools/lint-docs/src/lib.rs
View file

@ -84,8 +84,8 @@ impl Lint {
for &expected in &["### Example", "### Explanation", "{{produces}}"] {
if expected == "{{produces}}" && self.is_ignored() {
if self.doc_contains("{{produces}}") {
return Err(format!(
"the lint example has `ignore`, but also contains the {{{{produces}}}} marker\n\
return Err(
"the lint example has `ignore`, but also contains the {{produces}} marker\n\
\n\
The documentation generator cannot generate the example output when the \
example is ignored.\n\
@ -111,7 +111,7 @@ impl Lint {
Replacing the output with the text of the example you \
compiled manually yourself.\n\
"
).into());
.into());
}
continue;
}
@ -519,11 +519,11 @@ impl<'a> LintExtractor<'a> {
let mut these_lints: Vec<_> = lints.iter().filter(|lint| lint.level == level).collect();
these_lints.sort_unstable_by_key(|lint| &lint.name);
for lint in &these_lints {
write!(result, "* [`{}`](#{})\n", lint.name, lint.name.replace("_", "-")).unwrap();
writeln!(result, "* [`{}`](#{})", lint.name, lint.name.replace('_', "-")).unwrap();
}
result.push('\n');
for lint in &these_lints {
write!(result, "## {}\n\n", lint.name.replace("_", "-")).unwrap();
write!(result, "## {}\n\n", lint.name.replace('_', "-")).unwrap();
for line in &lint.doc {
result.push_str(line);
result.push('\n');
@ -583,7 +583,7 @@ fn add_rename_redirect(level: Level, output: &mut String) {
let filename = level.doc_filename().replace(".md", ".html");
output.push_str(RENAME_START);
for (from, to) in *names {
write!(output, " \"#{from}\": \"{filename}#{to}\",\n").unwrap();
writeln!(output, " \"#{from}\": \"{filename}#{to}\",").unwrap();
}
output.push_str(RENAME_END);
}