Address review comments

This commit is contained in:
Paweł Romanowski 2018-10-02 22:10:04 +01:00
parent f7d35cc5a8
commit 87bf9e2056
9 changed files with 51 additions and 108 deletions

View file

@ -1,13 +1,3 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// run-rustfix
// Regression test for changes introduced while fixing #54505

View file

@ -1,13 +1,3 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// run-rustfix
// Regression test for changes introduced while fixing #54505

View file

@ -1,5 +1,5 @@
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:26:16
--> $DIR/issue-54505-no-literals.rs:16:16
|
LL | take_range(std::ops::Range { start: 0, end: 1 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -11,7 +11,7 @@ LL | take_range(std::ops::Range { start: 0, end: 1 });
found type `std::ops::Range<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:31:16
--> $DIR/issue-54505-no-literals.rs:21:16
|
LL | take_range(::std::ops::Range { start: 0, end: 1 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -23,7 +23,7 @@ LL | take_range(::std::ops::Range { start: 0, end: 1 });
found type `std::ops::Range<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:36:16
--> $DIR/issue-54505-no-literals.rs:26:16
|
LL | take_range(std::ops::RangeFrom { start: 1 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -35,7 +35,7 @@ LL | take_range(std::ops::RangeFrom { start: 1 });
found type `std::ops::RangeFrom<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:41:16
--> $DIR/issue-54505-no-literals.rs:31:16
|
LL | take_range(::std::ops::RangeFrom { start: 1 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -47,7 +47,7 @@ LL | take_range(::std::ops::RangeFrom { start: 1 });
found type `std::ops::RangeFrom<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:46:16
--> $DIR/issue-54505-no-literals.rs:36:16
|
LL | take_range(std::ops::RangeFull {});
| ^^^^^^^^^^^^^^^^^^^^^^
@ -59,7 +59,7 @@ LL | take_range(std::ops::RangeFull {});
found type `std::ops::RangeFull`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:51:16
--> $DIR/issue-54505-no-literals.rs:41:16
|
LL | take_range(::std::ops::RangeFull {});
| ^^^^^^^^^^^^^^^^^^^^^^^^
@ -71,7 +71,7 @@ LL | take_range(::std::ops::RangeFull {});
found type `std::ops::RangeFull`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:56:16
--> $DIR/issue-54505-no-literals.rs:46:16
|
LL | take_range(std::ops::RangeInclusive::new(0, 1));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -83,7 +83,7 @@ LL | take_range(std::ops::RangeInclusive::new(0, 1));
found type `std::ops::RangeInclusive<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:61:16
--> $DIR/issue-54505-no-literals.rs:51:16
|
LL | take_range(::std::ops::RangeInclusive::new(0, 1));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -95,7 +95,7 @@ LL | take_range(::std::ops::RangeInclusive::new(0, 1));
found type `std::ops::RangeInclusive<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:66:16
--> $DIR/issue-54505-no-literals.rs:56:16
|
LL | take_range(std::ops::RangeTo { end: 5 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -107,7 +107,7 @@ LL | take_range(std::ops::RangeTo { end: 5 });
found type `std::ops::RangeTo<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:71:16
--> $DIR/issue-54505-no-literals.rs:61:16
|
LL | take_range(::std::ops::RangeTo { end: 5 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -119,7 +119,7 @@ LL | take_range(::std::ops::RangeTo { end: 5 });
found type `std::ops::RangeTo<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:76:16
--> $DIR/issue-54505-no-literals.rs:66:16
|
LL | take_range(std::ops::RangeToInclusive { end: 5 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -131,7 +131,7 @@ LL | take_range(std::ops::RangeToInclusive { end: 5 });
found type `std::ops::RangeToInclusive<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-literals.rs:81:16
--> $DIR/issue-54505-no-literals.rs:71:16
|
LL | take_range(::std::ops::RangeToInclusive { end: 5 });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

View file

@ -1,13 +1,3 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// error-pattern: `#[panic_handler]` function required, but not found
// error-pattern: language item required, but not found: `eh_personality`

View file

@ -3,7 +3,7 @@ error: `#[panic_handler]` function required, but not found
error: language item required, but not found: `eh_personality`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-std.rs:31:16
--> $DIR/issue-54505-no-std.rs:21:16
|
LL | take_range(0..1);
| ^^^^
@ -15,7 +15,7 @@ LL | take_range(0..1);
found type `core::ops::Range<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-std.rs:36:16
--> $DIR/issue-54505-no-std.rs:26:16
|
LL | take_range(1..);
| ^^^
@ -27,7 +27,7 @@ LL | take_range(1..);
found type `core::ops::RangeFrom<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-std.rs:41:16
--> $DIR/issue-54505-no-std.rs:31:16
|
LL | take_range(..);
| ^^
@ -39,7 +39,7 @@ LL | take_range(..);
found type `core::ops::RangeFull`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-std.rs:46:16
--> $DIR/issue-54505-no-std.rs:36:16
|
LL | take_range(0..=1);
| ^^^^^
@ -51,7 +51,7 @@ LL | take_range(0..=1);
found type `core::ops::RangeInclusive<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-std.rs:51:16
--> $DIR/issue-54505-no-std.rs:41:16
|
LL | take_range(..5);
| ^^^
@ -63,7 +63,7 @@ LL | take_range(..5);
found type `core::ops::RangeTo<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505-no-std.rs:56:16
--> $DIR/issue-54505-no-std.rs:46:16
|
LL | take_range(..=42);
| ^^^^^

View file

@ -1,13 +1,3 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// run-rustfix
// Regression test for #54505 - range borrowing suggestion had

View file

@ -1,13 +1,3 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// run-rustfix
// Regression test for #54505 - range borrowing suggestion had

View file

@ -1,5 +1,5 @@
error[E0308]: mismatched types
--> $DIR/issue-54505.rs:24:16
--> $DIR/issue-54505.rs:14:16
|
LL | take_range(0..1);
| ^^^^
@ -11,7 +11,7 @@ LL | take_range(0..1);
found type `std::ops::Range<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505.rs:29:16
--> $DIR/issue-54505.rs:19:16
|
LL | take_range(1..);
| ^^^
@ -23,7 +23,7 @@ LL | take_range(1..);
found type `std::ops::RangeFrom<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505.rs:34:16
--> $DIR/issue-54505.rs:24:16
|
LL | take_range(..);
| ^^
@ -35,7 +35,7 @@ LL | take_range(..);
found type `std::ops::RangeFull`
error[E0308]: mismatched types
--> $DIR/issue-54505.rs:39:16
--> $DIR/issue-54505.rs:29:16
|
LL | take_range(0..=1);
| ^^^^^
@ -47,7 +47,7 @@ LL | take_range(0..=1);
found type `std::ops::RangeInclusive<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505.rs:44:16
--> $DIR/issue-54505.rs:34:16
|
LL | take_range(..5);
| ^^^
@ -59,7 +59,7 @@ LL | take_range(..5);
found type `std::ops::RangeTo<{integer}>`
error[E0308]: mismatched types
--> $DIR/issue-54505.rs:49:16
--> $DIR/issue-54505.rs:39:16
|
LL | take_range(..=42);
| ^^^^^