Comments only: change TODOs to FIXMEs and annotate them

This commit is contained in:
Tim Chevalier 2012-07-05 15:58:25 -07:00
parent 50d2e7e07e
commit 889be71cb4
13 changed files with 19 additions and 20 deletions

View file

@ -588,7 +588,8 @@ mod node {
* Used for rebalancing and to allocate stacks for traversals.
*/
type concat = {
left: @node,//TODO: Perhaps a `vec` instead of `left`/`right`
//FIXME (#2744): Perhaps a `vec` instead of `left`/`right`
left: @node,
right: @node,
char_len: uint,
byte_len: uint,
@ -732,7 +733,8 @@ mod node {
}
pure fn byte_len(node: @node) -> uint {
alt(*node) {//TODO: Could we do this without the pattern-matching?
//FIXME (#2744): Could we do this without the pattern-matching?
alt(*node) {
leaf(y) { ret y.byte_len; }
concat(y){ ret y.byte_len; }
}
@ -805,7 +807,7 @@ mod node {
alt(leaf_iterator::next(it)) {
option::none { break; }
option::some(x) {
//TODO: Replace with memcpy or something similar
//FIXME (#2744): Replace with memcpy or something similar
let mut local_buf: ~[u8] =
unsafe::reinterpret_cast(*x.content);
let mut i = x.byte_offset;

View file

@ -2,7 +2,7 @@
import core::option;
// TODO: Windows support.
// FIXME (#2807): Windows support.
const color_black: u8 = 0u8;
const color_red: u8 = 1u8;

View file

@ -55,7 +55,7 @@ fn find<K: copy, V: copy>(m: &const tree_edge<K, V>, k: K) -> option<V> {
alt copy *m {
none { none }
// TODO: was that an optimization?
// FIXME (#2808): was that an optimization?
some(node) {
if k == node.key {
some(node.value)