From 8d333a3cbbae57ce7813c1529fdf597ad258c931 Mon Sep 17 00:00:00 2001 From: xiongmao86 Date: Sat, 4 Jan 2020 11:27:24 +0800 Subject: [PATCH] Extend spans to include !. --- clippy_lints/src/methods/mod.rs | 2 +- tests/ui/filetype_is_file.stderr | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs index b833fb55157d..a56334dc150f 100644 --- a/clippy_lints/src/methods/mod.rs +++ b/clippy_lints/src/methods/mod.rs @@ -3275,7 +3275,7 @@ fn lint_filetype_is_file(cx: &LateContext<'_, '_>, expr: &hir::Expr<'_>, args: & then { let lint_msg = "`!FileType::is_file()` does not deny all readable file types"; let help_msg = "use `FileType::is_dir()` instead"; - span_help_and_lint(cx, FILETYPE_IS_FILE, expr.span, lint_msg, help_msg); + span_help_and_lint(cx, FILETYPE_IS_FILE, parent.span, lint_msg, help_msg); } else { let lint_msg = "`FileType::is_file()` does not cover all readable file types"; let help_msg = "use `!FileType::is_dir()` instead"; diff --git a/tests/ui/filetype_is_file.stderr b/tests/ui/filetype_is_file.stderr index 298cb5ad0657..08bebbd796ed 100644 --- a/tests/ui/filetype_is_file.stderr +++ b/tests/ui/filetype_is_file.stderr @@ -8,10 +8,10 @@ LL | if fs::metadata("foo.txt")?.file_type().is_file() { = help: use `!FileType::is_dir()` instead error: `!FileType::is_file()` does not deny all readable file types - --> $DIR/filetype_is_file.rs:13:9 + --> $DIR/filetype_is_file.rs:13:8 | LL | if !fs::metadata("foo.txt")?.file_type().is_file() { - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use `FileType::is_dir()` instead