user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

auto merge of #9774 : sebcrozet/rust/master, r=huonw

Browse source 
The minimum (negative) value of a float is `-Bounded::max_value()`, not `Bounded::min_value()`.
Otherwise the following has an incorrect behavior:

```rust
let a = -1.0f64;
let b: f32 = NumCast::from(a); // incorrectly returns None
```
This commit is contained in:
bors 2013-10-09 17:41:23 -07:00
commit 8f4b87290b
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/libstd/num/num.rs
View file

@ -567,9 +567,8 @@ macro_rules! impl_to_primitive_float_to_float(
Some(*self as $DstT)
} else {
let n = *self as f64;
let min_value: $SrcT = Bounded::min_value();
let max_value: $SrcT = Bounded::max_value();
if min_value as f64 <= n && n <= max_value as f64 {
if -max_value as f64 <= n && n <= max_value as f64 {
Some(*self as $DstT)
} else {
None