user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Create a separate, tool-only suggestion for the comma

Browse source 
That way the comma isn't highlighted as part of the option in the UI.

Weirdly, the comma removal suggestion shows up in the UI.
This commit is contained in:
Camelid 2020-06-16 12:43:03 -07:00
parent 4ba66970d8
commit 8fe6710b4d
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/librustc_builtin_macros/asm.rs
View file

@ -294,6 +294,14 @@ fn err_duplicate_option<'a>(p: &mut Parser<'a>, symbol: Symbol, span: Span) {
String::new(),
Applicability::MachineApplicable,
);
if p.look_ahead(0, |t| t == &token::Comma) {
err.tool_only_span_suggestion(
p.token.span,
"remove this comma",
String::new(),
Applicability::MachineApplicable,
);
}
err.emit();
}
@ -306,11 +314,7 @@ fn try_set_option<'a>(
if !args.options.contains(option) {
args.options |= option;
} else {
let mut span = p.prev_token.span;
if p.look_ahead(0, |t| t == &token::Comma) {
span = span.to(p.token.span);
}
err_duplicate_option(p, symbol, span);
err_duplicate_option(p, symbol, p.prev_token.span);
}
}