user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf(manual_is_power_of_two): perform the is_integer_literal check first

Browse source 
.. as it's much cheaper than `count_ones_receiver`
This commit is contained in:
Ada Alakbarova 2025-11-07 21:37:51 +01:00
parent dddaf0768c
commit 9147a36ba6
No known key found for this signature in database
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
clippy_lints/src/manual_is_power_of_two.rs
View file

@ -70,12 +70,12 @@ impl<'tcx> LateLintPass<'tcx> for ManualIsPowerOfTwo {
if !expr.span.from_expansion()
&& let Some((lhs, rhs)) = unexpanded_binop_operands(expr, BinOpKind::Eq)
{
if let Some(a) = count_ones_receiver(cx, lhs)
&& is_integer_literal(rhs, 1)
if is_integer_literal(rhs, 1)
&& let Some(a) = count_ones_receiver(cx, lhs)
{
self.build_sugg(cx, expr, a);
} else if let Some(a) = count_ones_receiver(cx, rhs)
&& is_integer_literal(lhs, 1)
} else if is_integer_literal(lhs, 1)
&& let Some(a) = count_ones_receiver(cx, rhs)
{
self.build_sugg(cx, expr, a);
} else if is_integer_literal(rhs, 0)