From 915ff0b9699c9cf39b5d80fc3aeb6c7e047dd280 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Esteban=20K=C3=BCber?= Date: Sat, 21 Jul 2018 17:17:49 -0700 Subject: [PATCH] fix logic bug --- src/libsyntax_ext/format.rs | 4 ++-- src/test/ui/feature-gate-format_args_nl.rs | 0 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 src/test/ui/feature-gate-format_args_nl.rs diff --git a/src/libsyntax_ext/format.rs b/src/libsyntax_ext/format.rs index c63cc3727eda..755d2b476b71 100644 --- a/src/libsyntax_ext/format.rs +++ b/src/libsyntax_ext/format.rs @@ -698,8 +698,8 @@ pub fn expand_format_args_nl<'cx>(ecx: &'cx mut ExtCtxt, // For some reason, the only one that actually works for `println` is the first check if !sp.allows_unstable() // the enclosing span is marked as `#[allow_insternal_unsable]` - || !ecx.ecfg.enable_allow_internal_unstable() // NOTE: when is this enabled? - || !ecx.ecfg.enable_format_args_nl() // enabled using `#[feature(format_args_nl]` + && !ecx.ecfg.enable_allow_internal_unstable() // NOTE: when is this enabled? + && !ecx.ecfg.enable_format_args_nl() // enabled using `#[feature(format_args_nl]` { feature_gate::emit_feature_err(&ecx.parse_sess, "format_args_nl", diff --git a/src/test/ui/feature-gate-format_args_nl.rs b/src/test/ui/feature-gate-format_args_nl.rs new file mode 100644 index 000000000000..e69de29bb2d1