From 92d4164aca3647f08534a721bddec581a769a34a Mon Sep 17 00:00:00 2001 From: hi-rustin Date: Tue, 15 Jun 2021 16:26:10 +0800 Subject: [PATCH] better code --- compiler/rustc_middle/src/middle/stability.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/compiler/rustc_middle/src/middle/stability.rs b/compiler/rustc_middle/src/middle/stability.rs index 9d95b5bbb43f..2804fe580615 100644 --- a/compiler/rustc_middle/src/middle/stability.rs +++ b/compiler/rustc_middle/src/middle/stability.rs @@ -233,12 +233,12 @@ fn late_report_deprecation( if span.in_derive_expansion() { return; } - - tcx.struct_span_lint_hir(lint, hir_id, method_span.unwrap_or(span), |lint| { + let method_span = method_span.unwrap_or(span); + tcx.struct_span_lint_hir(lint, hir_id, method_span, |lint| { let mut diag = lint.build(message); if let hir::Node::Expr(_) = tcx.hir().get(hir_id) { let kind = tcx.def_kind(def_id).descr(def_id); - deprecation_suggestion(&mut diag, kind, suggestion, method_span.unwrap_or(span)); + deprecation_suggestion(&mut diag, kind, suggestion, method_span); } diag.emit() });