From 9315a0cd4c3b9568e66cf613fecad1bfac214f53 Mon Sep 17 00:00:00 2001 From: hyd-dev Date: Fri, 13 Aug 2021 00:11:44 +0800 Subject: [PATCH] Add tests for `#[no_mangle]` in `impl` blocks that looks like generic `impl` blocks but are actually not --- src/test/ui/generics/generic-no-mangle.fixed | 27 +++++++++++++++++++ src/test/ui/generics/generic-no-mangle.rs | 27 +++++++++++++++++++ src/test/ui/generics/generic-no-mangle.stderr | 6 ++--- 3 files changed, 57 insertions(+), 3 deletions(-) diff --git a/src/test/ui/generics/generic-no-mangle.fixed b/src/test/ui/generics/generic-no-mangle.fixed index 4523cac2c281..9126ac167cf2 100644 --- a/src/test/ui/generics/generic-no-mangle.fixed +++ b/src/test/ui/generics/generic-no-mangle.fixed @@ -89,6 +89,11 @@ impl Bar { pub fn baz() {} //~ ERROR functions generic over types or consts must be mangled } +impl Bar { + #[no_mangle] + pub fn qux() {} +} + trait Trait3 { fn foo(); extern "C" fn bar(); @@ -121,6 +126,14 @@ trait Trait4 { fn bar<'a>(x: &'a i32) -> &i32; } +impl Trait4 for Bar { + #[no_mangle] + fn foo() {} + + #[no_mangle] + fn bar<'b>(x: &'b i32) -> &i32 { x } +} + impl<'a> Trait4 for Baz<'a> { #[no_mangle] fn foo() {} @@ -129,4 +142,18 @@ impl<'a> Trait4 for Baz<'a> { fn bar<'b>(x: &'b i32) -> &i32 { x } } +trait Trait5 { + fn foo(); +} + +impl Trait5 for Foo { + #[no_mangle] + fn foo() {} +} + +impl Trait5 for Bar { + #[no_mangle] + fn foo() {} +} + fn main() {} diff --git a/src/test/ui/generics/generic-no-mangle.rs b/src/test/ui/generics/generic-no-mangle.rs index 83fd4564e91d..e283cf4bfe54 100644 --- a/src/test/ui/generics/generic-no-mangle.rs +++ b/src/test/ui/generics/generic-no-mangle.rs @@ -89,6 +89,11 @@ impl Bar { pub fn baz() {} //~ ERROR functions generic over types or consts must be mangled } +impl Bar { + #[no_mangle] + pub fn qux() {} +} + trait Trait3 { fn foo(); extern "C" fn bar(); @@ -121,6 +126,14 @@ trait Trait4 { fn bar<'a>(x: &'a i32) -> &i32; } +impl Trait4 for Bar { + #[no_mangle] + fn foo() {} + + #[no_mangle] + fn bar<'b>(x: &'b i32) -> &i32 { x } +} + impl<'a> Trait4 for Baz<'a> { #[no_mangle] fn foo() {} @@ -129,4 +142,18 @@ impl<'a> Trait4 for Baz<'a> { fn bar<'b>(x: &'b i32) -> &i32 { x } } +trait Trait5 { + fn foo(); +} + +impl Trait5 for Foo { + #[no_mangle] + fn foo() {} +} + +impl Trait5 for Bar { + #[no_mangle] + fn foo() {} +} + fn main() {} diff --git a/src/test/ui/generics/generic-no-mangle.stderr b/src/test/ui/generics/generic-no-mangle.stderr index 0786081f732f..adfddbe9ca79 100644 --- a/src/test/ui/generics/generic-no-mangle.stderr +++ b/src/test/ui/generics/generic-no-mangle.stderr @@ -117,7 +117,7 @@ LL | pub fn baz() {} | ^^^^^^^^^^^^^^^^^^ error: functions generic over types or consts must be mangled - --> $DIR/generic-no-mangle.rs:100:5 + --> $DIR/generic-no-mangle.rs:105:5 | LL | #[no_mangle] | ------------ help: remove this attribute @@ -125,7 +125,7 @@ LL | fn foo() {} | ^^^^^^^^^^^ error: functions generic over types or consts must be mangled - --> $DIR/generic-no-mangle.rs:103:5 + --> $DIR/generic-no-mangle.rs:108:5 | LL | #[no_mangle] | ------------ help: remove this attribute @@ -133,7 +133,7 @@ LL | extern "C" fn bar() {} | ^^^^^^^^^^^^^^^^^^^^^^ error: functions generic over types or consts must be mangled - --> $DIR/generic-no-mangle.rs:106:5 + --> $DIR/generic-no-mangle.rs:111:5 | LL | #[no_mangle] | ------------ help: remove this attribute