user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #29148 - petrochenkov:noshow, r=alexcrichton

Browse source 
Closes https://github.com/rust-lang/rust/issues/29145

[breaking-change], needs a crater run.
This commit is contained in:
bors 2015-10-20 19:02:27 +00:00
commit 97ba52ec37
9 changed files with 19 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/doc/style/features/traits/common.md
View file

@ -9,18 +9,18 @@ applicable, common traits.
To see why, consider the following situation:
* Crate `std` defines trait `Show`.
* Crate `url` defines type `Url`, without implementing `Show`.
* Crate `std` defines trait `Debug`.
* Crate `url` defines type `Url`, without implementing `Debug`.
* Crate `webapp` imports from both `std` and `url`,
There is no way for `webapp` to add `Show` to `url`, since it defines neither.
There is no way for `webapp` to add `Debug` to `url`, since it defines neither.
(Note: the newtype pattern can provide an efficient, but inconvenient
workaround; see [newtype for views](../types/newtype.md))
The most important common traits to implement from `std` are:
```rust
Clone, Show, Hash, Eq
Clone, Debug, Hash, Eq
```
#### When safe, derive or otherwise implement `Send` and `Share`. [FIXME]