user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Review comments

Browse source 
- Changed the separator from '+' to ','.
- Moved the branch protection options from -C to -Z.
- Additional test for incorrect branch-protection option.
- Remove LLVM < 12 code.
- Style fixes.

Co-authored-by: James McGregor <james.mcgregor2@arm.com>
This commit is contained in:
Jamie Cunliffe 2021-12-01 15:56:59 +00:00
parent 837cc1687f
commit 984ca4689d
12 changed files with 57 additions and 120 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/test/codegen/branch-protection.rs
View file

@ -3,10 +3,10 @@
// revisions: bti pac-ret leaf b-key
// min-llvm-version: 12.0.0
// needs-llvm-components: aarch64
// [bti] compile-flags: -C branch-protection=bti
// [pac-ret] compile-flags: -C branch-protection=pac-ret
// [leaf] compile-flags: -C branch-protection=pac-ret+leaf
// [b-key] compile-flags: -C branch-protection=pac-ret+b-key
// [bti] compile-flags: -Z branch-protection=bti
// [pac-ret] compile-flags: -Z branch-protection=pac-ret
// [leaf] compile-flags: -Z branch-protection=pac-ret,leaf
// [b-key] compile-flags: -Z branch-protection=pac-ret,b-key
// compile-flags: --target aarch64-unknown-linux-gnu
#![crate_type = "lib"]