user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lint: convert incoherent_fundamental_impls into hard error

Browse source 
Also remove it from lint listings.
This commit is contained in:
Hoàng Đức Hiếu 2018-05-10 12:42:03 +07:00 • committed by Hoàng Đức Hiếu
parent 2975a3c4be
commit 9982e7d407
8 changed files with 34 additions and 113 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/test/ui/issues/issue-43355.rs
View file

@ -12,7 +12,6 @@ impl<X, T> Trait1<X> for T where T: Trait2<X> {
impl<X> Trait1<Box<X>> for A {
//~^ ERROR conflicting implementations of trait
//~| hard error
//~| downstream crates may implement trait `Trait2<std::boxed::Box<_>>` for type `A`
type Output = i32;
}

6
src/test/ui/issues/issue-43355.stderr
View file

@ -1,4 +1,4 @@
error: conflicting implementations of trait `Trait1<std::boxed::Box<_>>` for type `A`: (E0119)
error[E0119]: conflicting implementations of trait `Trait1<std::boxed::Box<_>>` for type `A`:
--> $DIR/issue-43355.rs:13:1
|
LL | impl<X, T> Trait1<X> for T where T: Trait2<X> {
@ -7,10 +7,8 @@ LL | impl<X, T> Trait1<X> for T where T: Trait2<X> {
LL | impl<X> Trait1<Box<X>> for A {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `A`
|
= note: #[deny(incoherent_fundamental_impls)] on by default
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
= note: downstream crates may implement trait `Trait2<std::boxed::Box<_>>` for type `A`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0119`.