user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rollup merge of #73361 - estebank:non-primitive-cast, r=davidtwco

Browse source 
Tweak "non-primitive cast" error

- Suggest borrowing expression if it would allow cast to work.
- Suggest using `<Type>::from(<expr>)` when appropriate.
- Minor tweak to `;` typo suggestion.

Partily address #47136.
This commit is contained in:
Manish Goregaokar 2020-06-18 15:20:57 -07:00 • committed by GitHub
commit 9ca811772c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
35 changed files with 204 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/test/ui/cast/cast-from-nil.stderr
View file

@ -2,9 +2,7 @@ error[E0605]: non-primitive cast: `()` as `u32`
--> $DIR/cast-from-nil.rs:2:21
|
LL | fn main() { let u = (assert!(true) as u32); }
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error

8
src/test/ui/cast/cast-to-bare-fn.stderr
View file

@ -2,17 +2,13 @@ error[E0605]: non-primitive cast: `fn(isize) {foo}` as `extern "C" fn() -> isize
--> $DIR/cast-to-bare-fn.rs:5:13
|
LL | let x = foo as extern "C" fn() -> isize;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ invalid cast
error[E0605]: non-primitive cast: `u64` as `fn(isize) -> (isize, isize)`
--> $DIR/cast-to-bare-fn.rs:7:13
|
LL | let y = v as extern "Rust" fn(isize) -> (isize, isize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ invalid cast
error: aborting due to 2 previous errors

4
src/test/ui/cast/cast-to-nil.stderr
View file

@ -2,9 +2,7 @@ error[E0605]: non-primitive cast: `u32` as `()`
--> $DIR/cast-to-nil.rs:2:21
|
LL | fn main() { let u = 0u32 as (); }
| ^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error

2
src/test/ui/cast/cast-to-unsized-trait-object-suggestion.stderr
View file

@ -12,7 +12,7 @@ error[E0620]: cast to unsized type: `std::boxed::Box<{integer}>` as `dyn std::ma
LL | Box::new(1) as dyn Send;
| ^^^^^^^^^^^^^^^--------
| |
| help: try casting to a `Box` instead: `Box<dyn Send>`
| help: you can cast to a `Box` instead: `Box<dyn Send>`
error: aborting due to 2 previous errors

4
src/test/ui/closures/closure-no-fn-3.stderr
View file

@ -2,9 +2,7 @@ error[E0605]: non-primitive cast: `[closure@$DIR/closure-no-fn-3.rs:6:27: 6:37 b
--> $DIR/closure-no-fn-3.rs:6:27
|
LL | let baz: fn() -> u8 = (|| { b }) as fn() -> u8;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^^^^^^^^ invalid cast
error: aborting due to previous error

8
src/test/ui/coercion/coerce-to-bang-cast.stderr
View file

@ -2,17 +2,13 @@ error[E0605]: non-primitive cast: `i32` as `!`
--> $DIR/coerce-to-bang-cast.rs:6:13
|
LL | let y = {return; 22} as !;
| ^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0605]: non-primitive cast: `i32` as `!`
--> $DIR/coerce-to-bang-cast.rs:11:13
|
LL | let y = 22 as !;
| ^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to 2 previous errors

2
src/test/ui/consts/const-eval/const-eval-overflow-4b.stderr
View file

@ -16,7 +16,7 @@ error[E0604]: only `u8` can be cast as `char`, not `i8`
--> $DIR/const-eval-overflow-4b.rs:25:13
|
LL | : [u32; 5i8 as char as usize]
| ^^^^^^^^^^^
| ^^^^^^^^^^^ invalid cast
error: aborting due to 3 previous errors

2
src/test/ui/error-codes/E0604.stderr
View file

@ -2,7 +2,7 @@ error[E0604]: only `u8` can be cast as `char`, not `u32`
--> $DIR/E0604.rs:2:5
|
LL | 1u32 as char;
| ^^^^^^^^^^^^
| ^^^^^^^^^^^^ invalid cast
error: aborting due to previous error

8
src/test/ui/error-codes/E0605.stderr
View file

@ -2,17 +2,13 @@ error[E0605]: non-primitive cast: `u8` as `std::vec::Vec<u8>`
--> $DIR/E0605.rs:3:5
|
LL | x as Vec<u8>;
| ^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0605]: non-primitive cast: `*const u8` as `&u8`
--> $DIR/E0605.rs:6:5
|
LL | v as &u8;
| ^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to 2 previous errors

6
src/test/ui/error-festival.stderr
View file

@ -42,15 +42,13 @@ error[E0604]: only `u8` can be cast as `char`, not `u32`
--> $DIR/error-festival.rs:25:5
|
LL | 0u32 as char;
| ^^^^^^^^^^^^
| ^^^^^^^^^^^^ invalid cast
error[E0605]: non-primitive cast: `u8` as `std::vec::Vec<u8>`
--> $DIR/error-festival.rs:29:5
|
LL | x as Vec<u8>;
| ^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0054]: cannot cast as `bool`
--> $DIR/error-festival.rs:33:24

4
src/test/ui/fat-ptr-cast.stderr
View file

@ -34,9 +34,7 @@ error[E0605]: non-primitive cast: `std::boxed::Box<[i32]>` as `usize`
--> $DIR/fat-ptr-cast.rs:14:5
|
LL | b as usize;
| ^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0606]: casting `*const [i32]` as `usize` is invalid
--> $DIR/fat-ptr-cast.rs:15:5

4
src/test/ui/issues/issue-10991.stderr
View file

@ -2,9 +2,7 @@ error[E0605]: non-primitive cast: `()` as `usize`
--> $DIR/issue-10991.rs:3:14
|
LL | let _t = nil as usize;
| ^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error

4
src/test/ui/issues/issue-16048.rs
View file

@ -18,12 +18,12 @@ impl<'a> Test<'a> for Foo<'a> {
}
impl<'a> NoLifetime for Foo<'a> {
fn get<'p, T : Test<'a>>(&self) -> T {
fn get<'p, T: Test<'a> + From<Foo<'a>>>(&self) -> T {
//~^ ERROR E0195
//~| NOTE lifetimes do not match method in trait
return *self as T;
//~^ ERROR non-primitive cast: `Foo<'a>` as `T`
//~| NOTE an `as` expression can only be used to convert between primitive types.
//~| NOTE an `as` expression can only be used to convert between primitive types
}
}

8
src/test/ui/issues/issue-16048.stderr
View file

@ -4,16 +4,16 @@ error[E0195]: lifetime parameters or bounds on method `get` do not match the tra
LL | fn get<'p, T : Test<'p>>(&self) -> T;
| ------------------ lifetimes in impl do not match this method in trait
...
LL | fn get<'p, T : Test<'a>>(&self) -> T {
| ^^^^^^^^^^^^^^^^^^ lifetimes do not match method in trait
LL | fn get<'p, T: Test<'a> + From<Foo<'a>>>(&self) -> T {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetimes do not match method in trait
error[E0605]: non-primitive cast: `Foo<'a>` as `T`
--> $DIR/issue-16048.rs:24:16
|
LL | return *self as T;
| ^^^^^^^^^^
| ^^^^^^^^^^ help: consider using the `From` trait instead: `T::from(*self)`
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
= note: an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to 2 previous errors

2
src/test/ui/issues/issue-17441.stderr
View file

@ -16,7 +16,7 @@ error[E0620]: cast to unsized type: `std::boxed::Box<usize>` as `dyn std::fmt::D
LL | let _bar = Box::new(1_usize) as dyn std::fmt::Debug;
| ^^^^^^^^^^^^^^^^^^^^^-------------------
| |
| help: try casting to a `Box` instead: `Box<dyn std::fmt::Debug>`
| help: you can cast to a `Box` instead: `Box<dyn std::fmt::Debug>`
error[E0620]: cast to unsized type: `usize` as `dyn std::fmt::Debug`
--> $DIR/issue-17441.rs:8:16

7
src/test/ui/issues/issue-22289.stderr
View file

@ -2,9 +2,12 @@ error[E0605]: non-primitive cast: `i32` as `&(dyn std::any::Any + 'static)`
--> $DIR/issue-22289.rs:2:5
|
LL | 0 as &dyn std::any::Any;
| ^^^^^^^^^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^^^^^^^^^ invalid cast
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
help: borrow the value for the cast to be valid
|
LL | &0 as &dyn std::any::Any;
| ^
error: aborting due to previous error

2
src/test/ui/issues/issue-22312.rs
View file

@ -1,6 +1,6 @@
use std::ops::Index;
pub trait Array2D: Index<usize> {
pub trait Array2D: Index<usize> + Sized {
fn rows(&self) -> usize;
fn columns(&self) -> usize;
fn get<'a>(&'a self, y: usize, x: usize) -> Option<&'a <Self as Index<usize>>::Output> {

7
src/test/ui/issues/issue-22312.stderr
View file

@ -2,9 +2,12 @@ error[E0605]: non-primitive cast: `Self` as `&dyn std::ops::Index<usize, Output
--> $DIR/issue-22312.rs:11:24
|
LL | let indexer = &(*self as &dyn Index<usize, Output = <Self as Index<usize>>::Output>);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ invalid cast
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
help: borrow the value for the cast to be valid
|
LL | let indexer = &(&*self as &dyn Index<usize, Output = <Self as Index<usize>>::Output>);
| ^
error: aborting due to previous error

4
src/test/ui/issues/issue-2995.stderr
View file

@ -2,9 +2,7 @@ error[E0605]: non-primitive cast: `*const isize` as `&isize`
--> $DIR/issue-2995.rs:2:22
|
LL | let _q: &isize = p as &isize;
| ^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error

18
src/test/ui/issues/issue-45730.stderr
View file

@ -1,30 +1,24 @@
error[E0641]: cannot cast to a pointer of an unknown kind
--> $DIR/issue-45730.rs:3:23
--> $DIR/issue-45730.rs:3:28
|
LL | let x: *const _ = 0 as _;
| ^^^^^-
| |
| help: consider giving more type information
| ^ needs more type information
|
= note: the type information given here is insufficient to check whether the pointer cast is valid
error[E0641]: cannot cast to a pointer of an unknown kind
--> $DIR/issue-45730.rs:5:23
--> $DIR/issue-45730.rs:5:28
|
LL | let x: *const _ = 0 as *const _;
| ^^^^^--------
| |
| help: consider giving more type information
| ^^^^^^^^ needs more type information
|
= note: the type information given here is insufficient to check whether the pointer cast is valid
error[E0641]: cannot cast to a pointer of an unknown kind
--> $DIR/issue-45730.rs:8:13
--> $DIR/issue-45730.rs:8:44
|
LL | let x = 0 as *const i32 as *const _ as *mut _;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------
| |
| help: consider giving more type information
| ^^^^^^ needs more type information
|
= note: the type information given here is insufficient to check whether the pointer cast is valid

22
src/test/ui/mismatched_types/cast-rfc0401.stderr
View file

@ -24,41 +24,31 @@ error[E0605]: non-primitive cast: `*const u8` as `&u8`
--> $DIR/cast-rfc0401.rs:29:13
|
LL | let _ = v as &u8;
| ^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0605]: non-primitive cast: `*const u8` as `E`
--> $DIR/cast-rfc0401.rs:30:13
|
LL | let _ = v as E;
| ^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0605]: non-primitive cast: `*const u8` as `fn()`
--> $DIR/cast-rfc0401.rs:31:13
|
LL | let _ = v as fn();
| ^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^ invalid cast
error[E0605]: non-primitive cast: `*const u8` as `(u32,)`
--> $DIR/cast-rfc0401.rs:32:13
|
LL | let _ = v as (u32,);
| ^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0605]: non-primitive cast: `std::option::Option<&*const u8>` as `*const u8`
--> $DIR/cast-rfc0401.rs:33:13
|
LL | let _ = Some(&v) as *const u8;
| ^^^^^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error[E0606]: casting `*const u8` as `f32` is invalid
--> $DIR/cast-rfc0401.rs:35:13
@ -102,7 +92,7 @@ error[E0604]: only `u8` can be cast as `char`, not `u32`
--> $DIR/cast-rfc0401.rs:41:13
|
LL | let _ = 0x61u32 as char;
| ^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^ invalid cast
error[E0606]: casting `bool` as `f32` is invalid
--> $DIR/cast-rfc0401.rs:43:13

3
src/test/ui/mismatched_types/issue-26480.stderr
View file

@ -17,12 +17,11 @@ error[E0605]: non-primitive cast: `{integer}` as `()`
--> $DIR/issue-26480.rs:22:19
|
LL | ($x:expr) => ($x as ())
| ^^^^^^^^
| ^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
...
LL | cast!(2);
| --------- in this macro invocation
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 2 previous errors

16
src/test/ui/nonscalar-cast.fixed Normal file
View file

@ -0,0 +1,16 @@
// run-rustfix
#[derive(Debug)]
struct Foo {
x: isize
}
impl From<Foo> for isize {
fn from(val: Foo) -> isize {
val.x
}
}
fn main() {
println!("{}", isize::from(Foo { x: 1 })); //~ non-primitive cast: `Foo` as `isize` [E0605]
}

8
src/test/ui/nonscalar-cast.rs
View file

@ -1,8 +1,16 @@
// run-rustfix
#[derive(Debug)]
struct Foo {
x: isize
}
impl From<Foo> for isize {
fn from(val: Foo) -> isize {
val.x
}
}
fn main() {
println!("{}", Foo { x: 1 } as isize); //~ non-primitive cast: `Foo` as `isize` [E0605]
}

6
src/test/ui/nonscalar-cast.stderr
View file

@ -1,10 +1,10 @@
error[E0605]: non-primitive cast: `Foo` as `isize`
--> $DIR/nonscalar-cast.rs:7:20
--> $DIR/nonscalar-cast.rs:15:20
|
LL | println!("{}", Foo { x: 1 } as isize);
| ^^^^^^^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^^^^^^^ help: consider using the `From` trait instead: `isize::from(Foo { x: 1 })`
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
= note: an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error

6
src/test/ui/order-dependent-cast-inference.stderr
View file

@ -1,10 +1,8 @@
error[E0641]: cannot cast to a pointer of an unknown kind
--> $DIR/order-dependent-cast-inference.rs:5:17
--> $DIR/order-dependent-cast-inference.rs:5:22
|
LL | let mut y = 0 as *const _;
| ^^^^^--------
| |
| help: consider giving more type information
| ^^^^^^^^ needs more type information
|
= note: the type information given here is insufficient to check whether the pointer cast is valid

20
src/test/ui/tag-variant-cast-non-nullary.fixed Normal file
View file

@ -0,0 +1,20 @@
// run-rustfix
#![allow(dead_code, unused_variables)]
enum NonNullary {
Nullary,
Other(isize),
}
impl From<NonNullary> for isize {
fn from(val: NonNullary) -> isize {
match val {
NonNullary::Nullary => 0,
NonNullary::Other(i) => i,
}
}
}
fn main() {
let v = NonNullary::Nullary;
let val = isize::from(v); //~ ERROR non-primitive cast: `NonNullary` as `isize` [E0605]
}

11
src/test/ui/tag-variant-cast-non-nullary.rs
View file

@ -1,8 +1,19 @@
// run-rustfix
#![allow(dead_code, unused_variables)]
enum NonNullary {
Nullary,
Other(isize),
}
impl From<NonNullary> for isize {
fn from(val: NonNullary) -> isize {
match val {
NonNullary::Nullary => 0,
NonNullary::Other(i) => i,
}
}
}
fn main() {
let v = NonNullary::Nullary;
let val = v as isize; //~ ERROR non-primitive cast: `NonNullary` as `isize` [E0605]

6
src/test/ui/tag-variant-cast-non-nullary.stderr
View file

@ -1,10 +1,10 @@
error[E0605]: non-primitive cast: `NonNullary` as `isize`
--> $DIR/tag-variant-cast-non-nullary.rs:8:15
--> $DIR/tag-variant-cast-non-nullary.rs:19:15
|
LL | let val = v as isize;
| ^^^^^^^^^^
| ^^^^^^^^^^ help: consider using the `From` trait instead: `isize::from(v)`
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
= note: an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error

4
src/test/ui/type-alias-impl-trait/never_reveal_concrete_type.stderr
View file

@ -16,9 +16,7 @@ error[E0605]: non-primitive cast: `impl std::fmt::Debug` as `&'static str`
--> $DIR/never_reveal_concrete_type.rs:14:13
|
LL | let _ = x as &'static str;
| ^^^^^^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to 2 previous errors

4
src/test/ui/uninhabited/uninhabited-enum-cast.stderr
View file

@ -2,9 +2,7 @@ error[E0605]: non-primitive cast: `E` as `isize`
--> $DIR/uninhabited-enum-cast.rs:4:20
|
LL | println!("{}", (e as isize).to_string());
| ^^^^^^^^^^^^
|
= note: an `as` expression can only be used to convert between primitive types. Consider using the `From` trait
| ^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object
error: aborting due to previous error