From 748ad9fb4bf2d19e240a9bee886a92c7b1954a00 Mon Sep 17 00:00:00 2001 From: Mark Mansi Date: Sun, 25 Mar 2018 20:34:44 -0500 Subject: [PATCH 1/5] i128 is stable --- tests/ui/replace_consts.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ui/replace_consts.rs b/tests/ui/replace_consts.rs index 31c58b4bb4e7..37c3f5f3885a 100644 --- a/tests/ui/replace_consts.rs +++ b/tests/ui/replace_consts.rs @@ -1,4 +1,4 @@ -#![feature(integer_atomics, i128, i128_type)] +#![feature(integer_atomics)] #![allow(blacklisted_name)] #![deny(replace_consts)] use std::sync::atomic::*; From a4d869ca76087ee8b8858b78371a015c317cd67a Mon Sep 17 00:00:00 2001 From: Mark Mansi Date: Sun, 25 Mar 2018 20:35:23 -0500 Subject: [PATCH 2/5] i128 is stable --- clippy_lints/src/lib.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index bec46ba180c6..a8475c3b54c9 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -2,8 +2,6 @@ #![feature(box_syntax)] #![feature(custom_attribute)] -#![feature(i128_type)] -#![feature(i128)] #![feature(rustc_private)] #![feature(slice_patterns)] #![feature(stmt_expr_attributes)] From f25d4fd2533a838b52c312b34c5657c3853b124c Mon Sep 17 00:00:00 2001 From: Mark Mansi Date: Sun, 25 Mar 2018 21:04:05 -0500 Subject: [PATCH 3/5] make it pass for now --- clippy_lints/src/lib.rs | 4 ++++ tests/ui/replace_consts.rs | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index a8475c3b54c9..dd6199cfc175 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -11,6 +11,10 @@ #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)] #![recursion_limit = "256"] +// FIXME(mark-i-m) remove after i128 stablization merges +#![allow(stable_features)] +#![feature(i128, i128_type)] + #[macro_use] extern crate rustc; extern crate rustc_typeck; diff --git a/tests/ui/replace_consts.rs b/tests/ui/replace_consts.rs index 37c3f5f3885a..4bd9c1d7caeb 100644 --- a/tests/ui/replace_consts.rs +++ b/tests/ui/replace_consts.rs @@ -1,6 +1,11 @@ #![feature(integer_atomics)] #![allow(blacklisted_name)] #![deny(replace_consts)] + +// FIXME(mark-i-m) remove after i128 stablization merges +#![allow(stable_features)] +#![feature(i128, i128_type)] + use std::sync::atomic::*; use std::sync::{ONCE_INIT, Once}; From e2d7ef9972634e60b6cfa3d61c0751759b9358f1 Mon Sep 17 00:00:00 2001 From: Mark Mansi Date: Sun, 25 Mar 2018 21:17:38 -0500 Subject: [PATCH 4/5] attempt fix stderr --- tests/ui/replace_consts.stderr | 240 ++++++++++++++------------------- 1 file changed, 102 insertions(+), 138 deletions(-) diff --git a/tests/ui/replace_consts.stderr b/tests/ui/replace_consts.stderr index fb2e71db1714..7bc7f30276b2 100644 --- a/tests/ui/replace_consts.stderr +++ b/tests/ui/replace_consts.stderr @@ -1,7 +1,7 @@ error: using `ATOMIC_BOOL_INIT` - --> $DIR/replace_consts.rs:11:17 + --> $DIR/replace_consts.rs:16:17 | -11 | { let foo = ATOMIC_BOOL_INIT; }; +16 | { let foo = ATOMIC_BOOL_INIT; }; | ^^^^^^^^^^^^^^^^ help: try this: `AtomicBool::new(false)` | note: lint level defined here @@ -9,210 +9,174 @@ note: lint level defined here | 3 | #![deny(replace_consts)] | ^^^^^^^^^^^^^^ - error: using `ATOMIC_ISIZE_INIT` - --> $DIR/replace_consts.rs:12:17 - | -12 | { let foo = ATOMIC_ISIZE_INIT; }; - | ^^^^^^^^^^^^^^^^^ help: try this: `AtomicIsize::new(0)` - -error: using `ATOMIC_I8_INIT` - --> $DIR/replace_consts.rs:13:17 - | -13 | { let foo = ATOMIC_I8_INIT; }; - | ^^^^^^^^^^^^^^ help: try this: `AtomicI8::new(0)` - -error: using `ATOMIC_I16_INIT` - --> $DIR/replace_consts.rs:14:17 - | -14 | { let foo = ATOMIC_I16_INIT; }; - | ^^^^^^^^^^^^^^^ help: try this: `AtomicI16::new(0)` - -error: using `ATOMIC_I32_INIT` - --> $DIR/replace_consts.rs:15:17 - | -15 | { let foo = ATOMIC_I32_INIT; }; - | ^^^^^^^^^^^^^^^ help: try this: `AtomicI32::new(0)` - -error: using `ATOMIC_I64_INIT` - --> $DIR/replace_consts.rs:16:17 - | -16 | { let foo = ATOMIC_I64_INIT; }; - | ^^^^^^^^^^^^^^^ help: try this: `AtomicI64::new(0)` - -error: using `ATOMIC_USIZE_INIT` --> $DIR/replace_consts.rs:17:17 | -17 | { let foo = ATOMIC_USIZE_INIT; }; - | ^^^^^^^^^^^^^^^^^ help: try this: `AtomicUsize::new(0)` - -error: using `ATOMIC_U8_INIT` +17 | { let foo = ATOMIC_ISIZE_INIT; }; + | ^^^^^^^^^^^^^^^^^ help: try this: `AtomicIsize::new(0)` +error: using `ATOMIC_I8_INIT` --> $DIR/replace_consts.rs:18:17 | -18 | { let foo = ATOMIC_U8_INIT; }; - | ^^^^^^^^^^^^^^ help: try this: `AtomicU8::new(0)` - -error: using `ATOMIC_U16_INIT` +18 | { let foo = ATOMIC_I8_INIT; }; + | ^^^^^^^^^^^^^^ help: try this: `AtomicI8::new(0)` +error: using `ATOMIC_I16_INIT` --> $DIR/replace_consts.rs:19:17 | -19 | { let foo = ATOMIC_U16_INIT; }; - | ^^^^^^^^^^^^^^^ help: try this: `AtomicU16::new(0)` - -error: using `ATOMIC_U32_INIT` +19 | { let foo = ATOMIC_I16_INIT; }; + | ^^^^^^^^^^^^^^^ help: try this: `AtomicI16::new(0)` +error: using `ATOMIC_I32_INIT` --> $DIR/replace_consts.rs:20:17 | -20 | { let foo = ATOMIC_U32_INIT; }; - | ^^^^^^^^^^^^^^^ help: try this: `AtomicU32::new(0)` - -error: using `ATOMIC_U64_INIT` +20 | { let foo = ATOMIC_I32_INIT; }; + | ^^^^^^^^^^^^^^^ help: try this: `AtomicI32::new(0)` +error: using `ATOMIC_I64_INIT` --> $DIR/replace_consts.rs:21:17 | -21 | { let foo = ATOMIC_U64_INIT; }; - | ^^^^^^^^^^^^^^^ help: try this: `AtomicU64::new(0)` - -error: using `MIN` +21 | { let foo = ATOMIC_I64_INIT; }; + | ^^^^^^^^^^^^^^^ help: try this: `AtomicI64::new(0)` +error: using `ATOMIC_USIZE_INIT` + --> $DIR/replace_consts.rs:22:17 + | +22 | { let foo = ATOMIC_USIZE_INIT; }; + | ^^^^^^^^^^^^^^^^^ help: try this: `AtomicUsize::new(0)` +error: using `ATOMIC_U8_INIT` --> $DIR/replace_consts.rs:23:17 | -23 | { let foo = std::isize::MIN; }; - | ^^^^^^^^^^^^^^^ help: try this: `isize::min_value()` - -error: using `MIN` +23 | { let foo = ATOMIC_U8_INIT; }; + | ^^^^^^^^^^^^^^ help: try this: `AtomicU8::new(0)` +error: using `ATOMIC_U16_INIT` --> $DIR/replace_consts.rs:24:17 | -24 | { let foo = std::i8::MIN; }; - | ^^^^^^^^^^^^ help: try this: `i8::min_value()` - -error: using `MIN` +24 | { let foo = ATOMIC_U16_INIT; }; + | ^^^^^^^^^^^^^^^ help: try this: `AtomicU16::new(0)` +error: using `ATOMIC_U32_INIT` --> $DIR/replace_consts.rs:25:17 | -25 | { let foo = std::i16::MIN; }; - | ^^^^^^^^^^^^^ help: try this: `i16::min_value()` - -error: using `MIN` +25 | { let foo = ATOMIC_U32_INIT; }; + | ^^^^^^^^^^^^^^^ help: try this: `AtomicU32::new(0)` +error: using `ATOMIC_U64_INIT` --> $DIR/replace_consts.rs:26:17 | -26 | { let foo = std::i32::MIN; }; - | ^^^^^^^^^^^^^ help: try this: `i32::min_value()` - -error: using `MIN` - --> $DIR/replace_consts.rs:27:17 - | -27 | { let foo = std::i64::MIN; }; - | ^^^^^^^^^^^^^ help: try this: `i64::min_value()` - +26 | { let foo = ATOMIC_U64_INIT; }; + | ^^^^^^^^^^^^^^^ help: try this: `AtomicU64::new(0)` error: using `MIN` --> $DIR/replace_consts.rs:28:17 | -28 | { let foo = std::i128::MIN; }; - | ^^^^^^^^^^^^^^ help: try this: `i128::min_value()` - +28 | { let foo = std::isize::MIN; }; + | ^^^^^^^^^^^^^^^ help: try this: `isize::min_value()` error: using `MIN` --> $DIR/replace_consts.rs:29:17 | -29 | { let foo = std::usize::MIN; }; - | ^^^^^^^^^^^^^^^ help: try this: `usize::min_value()` - +29 | { let foo = std::i8::MIN; }; + | ^^^^^^^^^^^^ help: try this: `i8::min_value()` error: using `MIN` --> $DIR/replace_consts.rs:30:17 | -30 | { let foo = std::u8::MIN; }; - | ^^^^^^^^^^^^ help: try this: `u8::min_value()` - +30 | { let foo = std::i16::MIN; }; + | ^^^^^^^^^^^^^ help: try this: `i16::min_value()` error: using `MIN` --> $DIR/replace_consts.rs:31:17 | -31 | { let foo = std::u16::MIN; }; - | ^^^^^^^^^^^^^ help: try this: `u16::min_value()` - +31 | { let foo = std::i32::MIN; }; + | ^^^^^^^^^^^^^ help: try this: `i32::min_value()` error: using `MIN` --> $DIR/replace_consts.rs:32:17 | -32 | { let foo = std::u32::MIN; }; - | ^^^^^^^^^^^^^ help: try this: `u32::min_value()` - +32 | { let foo = std::i64::MIN; }; + | ^^^^^^^^^^^^^ help: try this: `i64::min_value()` error: using `MIN` --> $DIR/replace_consts.rs:33:17 | -33 | { let foo = std::u64::MIN; }; - | ^^^^^^^^^^^^^ help: try this: `u64::min_value()` - +33 | { let foo = std::i128::MIN; }; + | ^^^^^^^^^^^^^^ help: try this: `i128::min_value()` error: using `MIN` --> $DIR/replace_consts.rs:34:17 | -34 | { let foo = std::u128::MIN; }; - | ^^^^^^^^^^^^^^ help: try this: `u128::min_value()` - -error: using `MAX` +34 | { let foo = std::usize::MIN; }; + | ^^^^^^^^^^^^^^^ help: try this: `usize::min_value()` +error: using `MIN` + --> $DIR/replace_consts.rs:35:17 + | +35 | { let foo = std::u8::MIN; }; + | ^^^^^^^^^^^^ help: try this: `u8::min_value()` +error: using `MIN` --> $DIR/replace_consts.rs:36:17 | -36 | { let foo = std::isize::MAX; }; - | ^^^^^^^^^^^^^^^ help: try this: `isize::max_value()` - -error: using `MAX` +36 | { let foo = std::u16::MIN; }; + | ^^^^^^^^^^^^^ help: try this: `u16::min_value()` +error: using `MIN` --> $DIR/replace_consts.rs:37:17 | -37 | { let foo = std::i8::MAX; }; - | ^^^^^^^^^^^^ help: try this: `i8::max_value()` - -error: using `MAX` +37 | { let foo = std::u32::MIN; }; + | ^^^^^^^^^^^^^ help: try this: `u32::min_value()` +error: using `MIN` --> $DIR/replace_consts.rs:38:17 | -38 | { let foo = std::i16::MAX; }; - | ^^^^^^^^^^^^^ help: try this: `i16::max_value()` - -error: using `MAX` +38 | { let foo = std::u64::MIN; }; + | ^^^^^^^^^^^^^ help: try this: `u64::min_value()` +error: using `MIN` --> $DIR/replace_consts.rs:39:17 | -39 | { let foo = std::i32::MAX; }; - | ^^^^^^^^^^^^^ help: try this: `i32::max_value()` - -error: using `MAX` - --> $DIR/replace_consts.rs:40:17 - | -40 | { let foo = std::i64::MAX; }; - | ^^^^^^^^^^^^^ help: try this: `i64::max_value()` - +39 | { let foo = std::u128::MIN; }; + | ^^^^^^^^^^^^^^ help: try this: `u128::min_value()` error: using `MAX` --> $DIR/replace_consts.rs:41:17 | -41 | { let foo = std::i128::MAX; }; - | ^^^^^^^^^^^^^^ help: try this: `i128::max_value()` - +41 | { let foo = std::isize::MAX; }; + | ^^^^^^^^^^^^^^^ help: try this: `isize::max_value()` error: using `MAX` --> $DIR/replace_consts.rs:42:17 | -42 | { let foo = std::usize::MAX; }; - | ^^^^^^^^^^^^^^^ help: try this: `usize::max_value()` - +42 | { let foo = std::i8::MAX; }; + | ^^^^^^^^^^^^ help: try this: `i8::max_value()` error: using `MAX` --> $DIR/replace_consts.rs:43:17 | -43 | { let foo = std::u8::MAX; }; - | ^^^^^^^^^^^^ help: try this: `u8::max_value()` - +43 | { let foo = std::i16::MAX; }; + | ^^^^^^^^^^^^^ help: try this: `i16::max_value()` error: using `MAX` --> $DIR/replace_consts.rs:44:17 | -44 | { let foo = std::u16::MAX; }; - | ^^^^^^^^^^^^^ help: try this: `u16::max_value()` - +44 | { let foo = std::i32::MAX; }; + | ^^^^^^^^^^^^^ help: try this: `i32::max_value()` error: using `MAX` --> $DIR/replace_consts.rs:45:17 | -45 | { let foo = std::u32::MAX; }; - | ^^^^^^^^^^^^^ help: try this: `u32::max_value()` - +45 | { let foo = std::i64::MAX; }; + | ^^^^^^^^^^^^^ help: try this: `i64::max_value()` error: using `MAX` --> $DIR/replace_consts.rs:46:17 | -46 | { let foo = std::u64::MAX; }; - | ^^^^^^^^^^^^^ help: try this: `u64::max_value()` - +46 | { let foo = std::i128::MAX; }; + | ^^^^^^^^^^^^^^ help: try this: `i128::max_value()` error: using `MAX` --> $DIR/replace_consts.rs:47:17 | -47 | { let foo = std::u128::MAX; }; +47 | { let foo = std::usize::MAX; }; + | ^^^^^^^^^^^^^^^ help: try this: `usize::max_value()` +error: using `MAX` + --> $DIR/replace_consts.rs:48:17 + | +48 | { let foo = std::u8::MAX; }; + | ^^^^^^^^^^^^ help: try this: `u8::max_value()` +error: using `MAX` + --> $DIR/replace_consts.rs:49:17 + | +49 | { let foo = std::u16::MAX; }; + | ^^^^^^^^^^^^^ help: try this: `u16::max_value()` +error: using `MAX` + --> $DIR/replace_consts.rs:50:17 + | +50 | { let foo = std::u32::MAX; }; + | ^^^^^^^^^^^^^ help: try this: `u32::max_value()` +error: using `MAX` + --> $DIR/replace_consts.rs:51:17 + | +51 | { let foo = std::u64::MAX; }; + | ^^^^^^^^^^^^^ help: try this: `u64::max_value()` +error: using `MAX` + --> $DIR/replace_consts.rs:52:17 + | +52 | { let foo = std::u128::MAX; }; | ^^^^^^^^^^^^^^ help: try this: `u128::max_value()` - error: aborting due to 35 previous errors - From e9f6a7c72f6fccb6bd3ff7858d9cea9afcaa40d9 Mon Sep 17 00:00:00 2001 From: Mark Mansi Date: Sun, 25 Mar 2018 21:26:10 -0500 Subject: [PATCH 5/5] whitespace --- tests/ui/replace_consts.stderr | 36 ++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/tests/ui/replace_consts.stderr b/tests/ui/replace_consts.stderr index 7bc7f30276b2..571bfc6e65bd 100644 --- a/tests/ui/replace_consts.stderr +++ b/tests/ui/replace_consts.stderr @@ -9,174 +9,210 @@ note: lint level defined here | 3 | #![deny(replace_consts)] | ^^^^^^^^^^^^^^ + error: using `ATOMIC_ISIZE_INIT` --> $DIR/replace_consts.rs:17:17 | 17 | { let foo = ATOMIC_ISIZE_INIT; }; | ^^^^^^^^^^^^^^^^^ help: try this: `AtomicIsize::new(0)` + error: using `ATOMIC_I8_INIT` --> $DIR/replace_consts.rs:18:17 | 18 | { let foo = ATOMIC_I8_INIT; }; | ^^^^^^^^^^^^^^ help: try this: `AtomicI8::new(0)` + error: using `ATOMIC_I16_INIT` --> $DIR/replace_consts.rs:19:17 | 19 | { let foo = ATOMIC_I16_INIT; }; | ^^^^^^^^^^^^^^^ help: try this: `AtomicI16::new(0)` + error: using `ATOMIC_I32_INIT` --> $DIR/replace_consts.rs:20:17 | 20 | { let foo = ATOMIC_I32_INIT; }; | ^^^^^^^^^^^^^^^ help: try this: `AtomicI32::new(0)` + error: using `ATOMIC_I64_INIT` --> $DIR/replace_consts.rs:21:17 | 21 | { let foo = ATOMIC_I64_INIT; }; | ^^^^^^^^^^^^^^^ help: try this: `AtomicI64::new(0)` + error: using `ATOMIC_USIZE_INIT` --> $DIR/replace_consts.rs:22:17 | 22 | { let foo = ATOMIC_USIZE_INIT; }; | ^^^^^^^^^^^^^^^^^ help: try this: `AtomicUsize::new(0)` + error: using `ATOMIC_U8_INIT` --> $DIR/replace_consts.rs:23:17 | 23 | { let foo = ATOMIC_U8_INIT; }; | ^^^^^^^^^^^^^^ help: try this: `AtomicU8::new(0)` + error: using `ATOMIC_U16_INIT` --> $DIR/replace_consts.rs:24:17 | 24 | { let foo = ATOMIC_U16_INIT; }; | ^^^^^^^^^^^^^^^ help: try this: `AtomicU16::new(0)` + error: using `ATOMIC_U32_INIT` --> $DIR/replace_consts.rs:25:17 | 25 | { let foo = ATOMIC_U32_INIT; }; | ^^^^^^^^^^^^^^^ help: try this: `AtomicU32::new(0)` + error: using `ATOMIC_U64_INIT` --> $DIR/replace_consts.rs:26:17 | 26 | { let foo = ATOMIC_U64_INIT; }; | ^^^^^^^^^^^^^^^ help: try this: `AtomicU64::new(0)` + error: using `MIN` --> $DIR/replace_consts.rs:28:17 | 28 | { let foo = std::isize::MIN; }; | ^^^^^^^^^^^^^^^ help: try this: `isize::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:29:17 | 29 | { let foo = std::i8::MIN; }; | ^^^^^^^^^^^^ help: try this: `i8::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:30:17 | 30 | { let foo = std::i16::MIN; }; | ^^^^^^^^^^^^^ help: try this: `i16::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:31:17 | 31 | { let foo = std::i32::MIN; }; | ^^^^^^^^^^^^^ help: try this: `i32::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:32:17 | 32 | { let foo = std::i64::MIN; }; | ^^^^^^^^^^^^^ help: try this: `i64::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:33:17 | 33 | { let foo = std::i128::MIN; }; | ^^^^^^^^^^^^^^ help: try this: `i128::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:34:17 | 34 | { let foo = std::usize::MIN; }; | ^^^^^^^^^^^^^^^ help: try this: `usize::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:35:17 | 35 | { let foo = std::u8::MIN; }; | ^^^^^^^^^^^^ help: try this: `u8::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:36:17 | 36 | { let foo = std::u16::MIN; }; | ^^^^^^^^^^^^^ help: try this: `u16::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:37:17 | 37 | { let foo = std::u32::MIN; }; | ^^^^^^^^^^^^^ help: try this: `u32::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:38:17 | 38 | { let foo = std::u64::MIN; }; | ^^^^^^^^^^^^^ help: try this: `u64::min_value()` + error: using `MIN` --> $DIR/replace_consts.rs:39:17 | 39 | { let foo = std::u128::MIN; }; | ^^^^^^^^^^^^^^ help: try this: `u128::min_value()` + error: using `MAX` --> $DIR/replace_consts.rs:41:17 | 41 | { let foo = std::isize::MAX; }; | ^^^^^^^^^^^^^^^ help: try this: `isize::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:42:17 | 42 | { let foo = std::i8::MAX; }; | ^^^^^^^^^^^^ help: try this: `i8::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:43:17 | 43 | { let foo = std::i16::MAX; }; | ^^^^^^^^^^^^^ help: try this: `i16::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:44:17 | 44 | { let foo = std::i32::MAX; }; | ^^^^^^^^^^^^^ help: try this: `i32::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:45:17 | 45 | { let foo = std::i64::MAX; }; | ^^^^^^^^^^^^^ help: try this: `i64::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:46:17 | 46 | { let foo = std::i128::MAX; }; | ^^^^^^^^^^^^^^ help: try this: `i128::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:47:17 | 47 | { let foo = std::usize::MAX; }; | ^^^^^^^^^^^^^^^ help: try this: `usize::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:48:17 | 48 | { let foo = std::u8::MAX; }; | ^^^^^^^^^^^^ help: try this: `u8::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:49:17 | 49 | { let foo = std::u16::MAX; }; | ^^^^^^^^^^^^^ help: try this: `u16::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:50:17 | 50 | { let foo = std::u32::MAX; }; | ^^^^^^^^^^^^^ help: try this: `u32::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:51:17 | 51 | { let foo = std::u64::MAX; }; | ^^^^^^^^^^^^^ help: try this: `u64::max_value()` + error: using `MAX` --> $DIR/replace_consts.rs:52:17 | 52 | { let foo = std::u128::MAX; }; | ^^^^^^^^^^^^^^ help: try this: `u128::max_value()` + error: aborting due to 35 previous errors +