Don't lint unit args if expression kind is path

2021-02-24 13:31:04 +01:00 · 2021-02-24 13:31:04 +01:00 · 9fe9d94abd
commit 9fe9d94abd
parent eb476c6c70
5 changed files with 19 additions and 96 deletions
--- a/clippy_lints/src/types.rs
+++ b/clippy_lints/src/types.rs
@ -955,16 +955,10 @@ impl<'tcx> LateLintPass<'tcx> for UnitArg {
                    .iter()
                    .filter(|arg| {
                        if is_unit(cx.typeck_results().expr_ty(arg)) && !is_unit_literal(arg) {
-                            match &arg.kind {
-                                ExprKind::Block(..)
-                                | ExprKind::Call(..)
-                                | ExprKind::If(..)
-                                | ExprKind::MethodCall(..) => true,
-                                ExprKind::Match(..) => {
-                                    !matches!(&arg.kind, ExprKind::Match(.., MatchSource::TryDesugar))
-                                },
-                                _ => false,
-                            }
+                            !matches!(
+                                &arg.kind,
+                                ExprKind::Match(.., MatchSource::TryDesugar) | ExprKind::Path(..)
+                            )
                        } else {
                            false
                        }