diff --git a/src/librustuv/addrinfo.rs b/src/librustuv/addrinfo.rs index 2fe4819c789c..2740671c00d6 100644 --- a/src/librustuv/addrinfo.rs +++ b/src/librustuv/addrinfo.rs @@ -183,39 +183,3 @@ pub fn accum_addrinfo(addr: &Addrinfo) -> ~[ai::Info] { return addrs; } } - -// cannot give tcp/ip permission without help of apk -#[cfg(test, not(target_os="android"))] -mod test { - use std::io::net::ip::{SocketAddr, Ipv4Addr}; - use super::super::local_loop; - use super::GetAddrInfoRequest; - - #[test] - fn getaddrinfo_test() { - let loop_ = &mut local_loop().loop_; - match GetAddrInfoRequest::run(loop_, Some("localhost"), None, None) { - Ok(infos) => { - let mut found_local = false; - let local_addr = &SocketAddr { - ip: Ipv4Addr(127, 0, 0, 1), - port: 0 - }; - for addr in infos.iter() { - found_local = found_local || addr.address == *local_addr; - } - assert!(found_local); - } - Err(e) => fail!("{:?}", e), - } - } - - #[test] - fn issue_10663() { - let loop_ = &mut local_loop().loop_; - // Something should happen here, but this certainly shouldn't cause - // everything to die. The actual outcome we don't care too much about. - GetAddrInfoRequest::run(loop_, Some("irc.n0v4.com"), None, - None); - } -} diff --git a/src/libstd/io/net/addrinfo.rs b/src/libstd/io/net/addrinfo.rs index fe29a1122622..4a8529d0a0aa 100644 --- a/src/libstd/io/net/addrinfo.rs +++ b/src/libstd/io/net/addrinfo.rs @@ -98,15 +98,15 @@ fn lookup(hostname: Option<&str>, servname: Option<&str>, hint: Option) LocalIo::maybe_raise(|io| io.get_host_addresses(hostname, servname, hint)) } -#[cfg(test)] +// Ignored on android since we cannot give tcp/ip +// permission without help of apk +#[cfg(test, not(target_os = "android"))] mod test { use io::net::ip::Ipv4Addr; use prelude::*; use super::*; - #[test] - #[ignore(cfg(target_os="android"))] // cannot give tcp/ip permission without help of apk - fn dns_smoke_test() { + iotest!(fn dns_smoke_test() { let ipaddrs = get_host_addresses("localhost").unwrap(); let mut found_local = false; let local_addr = &Ipv4Addr(127, 0, 0, 1); @@ -114,5 +114,11 @@ mod test { found_local = found_local || addr == local_addr; } assert!(found_local); - } + }) + + iotest!(fn issue_10663() { + // Something should happen here, but this certainly shouldn't cause + // everything to die. The actual outcome we don't care too much about. + get_host_addresses("example.com"); + } #[ignore]) }