Merge pull request #1093 from oli-obk/serde_specific_lint

lint on implementing `visit_string` without also implementing `visit_str`

clippy_lints/src/utils/internal_lints.rs

@@ -0,0 +1,53 @@
+use rustc::lint::*;
+use utils::span_lint;
+use syntax::parse::token::InternedString;
+use syntax::ast::*;
+
+/// **What it does:** This lint checks for various things we like to keep tidy in clippy
+///
+/// **Why is this bad?** ???
+///
+/// **Known problems:** None.
+///
+/// **Example:** wrong ordering of the util::paths constants
+declare_lint! {
+    pub CLIPPY_LINTS_INTERNAL, Allow,
+    "Various things that will negatively affect your clippy experience"
+}
+
+
+#[derive(Copy, Clone)]
+pub struct Clippy;
+
+impl LintPass for Clippy {
+    fn get_lints(&self) -> LintArray {
+        lint_array!(CLIPPY_LINTS_INTERNAL)
+    }
+}
+
+impl EarlyLintPass for Clippy {
+    fn check_crate(&mut self, cx: &EarlyContext, krate: &Crate) {
+        if let Some(utils) = krate.module.items.iter().find(|item| item.ident.name.as_str() == "utils") {
+            if let ItemKind::Mod(ref utils_mod) = utils.node {
+                if let Some(paths) = utils_mod.items.iter().find(|item| item.ident.name.as_str() == "paths") {
+                    if let ItemKind::Mod(ref paths_mod) = paths.node {
+                        let mut last_name: Option<InternedString> = None;
+                        for item in &paths_mod.items {
+                            let name = item.ident.name.as_str();
+                            if let Some(ref last_name) = last_name {
+                                if **last_name > *name {
+                                    span_lint(cx,
+                                              CLIPPY_LINTS_INTERNAL,
+                                              item.span,
+                                              "this constant should be before the previous constant due to lexical ordering",
+                                    );
+                                }
+                            }
+                            last_name = Some(name);
+                        }
+                    }
+                }
+            }
+        }
+    }
+}

clippy_lints/src/utils/mod.rs

@@ -25,6 +25,7 @@ pub mod conf;
 mod hir;
 pub mod paths;
 pub mod sugg;
+pub mod internal_lints;
 pub use self::hir::{SpanlessEq, SpanlessHash};
 
 pub type MethodArgs = HirVec<P<Expr>>;

clippy_lints/src/utils/paths.rs

@@ -54,6 +54,7 @@ pub const REGEX_BYTES_SET_NEW: [&'static str; 5] = ["regex", "re_set", "bytes",
 pub const REGEX_NEW: [&'static str; 4] = ["regex", "re_unicode", "Regex", "new"];
 pub const REGEX_SET_NEW: [&'static str; 5] = ["regex", "re_set", "unicode", "RegexSet", "new"];
 pub const RESULT: [&'static str; 3] = ["core", "result", "Result"];
+pub const SERDE_DE_VISITOR: [&'static str; 3] = ["serde", "de", "Visitor"];
 pub const STRING: [&'static str; 3] = ["collections", "string", "String"];
 pub const TRANSMUTE: [&'static str; 4] = ["core", "intrinsics", "", "transmute"];
 pub const VEC: [&'static str; 3] = ["collections", "vec", "Vec"];