user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

acle/dsp: note the difference between LLVM's +dsp and ACLE's __ARM_FEATURE_DSP

Browse source 
addresses https://github.com/rust-lang-nursery/stdsimd/pull/557#discussion_r256597576
This commit is contained in:
Jorge Aparicio 2019-02-14 12:49:36 +01:00 • committed by gnzlbg
parent 43cfda6670
commit a681e3b3f5
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
library/stdarch/crates/core_arch/src/acle/mod.rs
View file

@ -33,6 +33,14 @@
//! - `v6 < v8m < v6t2`
//! - `v7 < v8m.main`
//!
//! *NOTE*: Section 5.4.7 of ACLE says:
//!
//! - "__ARM_FEATURE_DSP is defined to 1 if the DSP (v5E) instructions are supported and the
//! intrinsics defined in Saturating intrinsics are available."
//!
//! This does *not* match how LLVM uses the '+dsp' feature; this feature is not set for v5te
//! targets so we have to work around this difference.
//!
//! # References
//!
//! - [ACLE Q2 2018](https://developer.arm.com/docs/101028/latest)
@ -54,6 +62,8 @@ pub use self::registers::*;
// Supported arches: 5TE, 7E-M. See Section 10.1 of ACLE (e.g. QADD)
// We also include the A profile even though DSP is deprecated on that profile as of ACLE 2.0 (see
// section 5.4.7)
// Here we workaround the difference between LLVM's +dsp and ACLE's __ARM_FEATURE_DSP by gating on
// '+v5te' rather than on '+dsp'
#[cfg(all(
not(target_arch = "aarch64"),
any(