user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #50653 - oli-obk:bad_const, r=cramertj

Browse source 
Make the `const_err` lint `deny`-by-default

At best these things are runtime panics (debug mode) or overflows (release mode). More likely they are public constants that are unused in the crate declaring them.

This is not a breaking change, as dependencies won't break and root crates can `#![warn(const_err)]`, though I don't know why anyone would do that.
This commit is contained in:
bors 2018-05-18 17:17:35 +00:00
commit a722296b6e
28 changed files with 95 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/test/ui/error-codes/E0080.stderr
View file

@ -12,15 +12,15 @@ error[E0080]: constant evaluation error
LL | X = (1 << 500), //~ ERROR E0080
| ^^^^^^^^^^ attempt to shift left with overflow
warning: attempt to divide by zero
error: attempt to divide by zero
--> $DIR/E0080.rs:14:9
|
LL | Y = (1 / 0) //~ ERROR E0080
| ^^^^^^^
|
= note: #[warn(const_err)] on by default
= note: #[deny(const_err)] on by default
warning: constant evaluation error
error: constant evaluation error
--> $DIR/E0080.rs:14:9
|
LL | Y = (1 / 0) //~ ERROR E0080
@ -32,6 +32,6 @@ error[E0080]: constant evaluation error
LL | Y = (1 / 0) //~ ERROR E0080
| ^^^^^^^ attempt to divide by zero
error: aborting due to 3 previous errors
error: aborting due to 5 previous errors
For more information about this error, try `rustc --explain E0080`.