diff --git a/src/liballoc/rc.rs b/src/liballoc/rc.rs index 837d709e8820..e651e375e3d5 100644 --- a/src/liballoc/rc.rs +++ b/src/liballoc/rc.rs @@ -909,6 +909,8 @@ trait RcBoxPtr { fn inc_strong(&self) { let strong = self.strong(); // The reference count is always at least one unless we're about to drop the type + // This allows the bulk of the destructor to be omitted in cases where we know that + // the reference count must be > 0. unsafe { assume(strong > 0); } self.inner().strong.set(strong + 1); } @@ -917,6 +919,8 @@ trait RcBoxPtr { fn dec_strong(&self) { let strong = self.strong(); // The reference count is always at least one unless we're about to drop the type + // This allows the bulk of the destructor to be omitted in cases where we know that + // the reference count must be > 0 unsafe { assume(strong > 0); } self.inner().strong.set(strong - 1); } @@ -936,7 +940,9 @@ impl RcBoxPtr for Rc { fn inner(&self) -> &RcBox { unsafe { // Safe to assume this here, as if it weren't true, we'd be breaking - // the contract anyway + // the contract anyway. + // This allows the null check to be elided in the destructor if we + // manipulated the reference count in the same function. assume(!self._ptr.is_null()); &(**self._ptr) } @@ -949,6 +955,8 @@ impl RcBoxPtr for Weak { unsafe { // Safe to assume this here, as if it weren't true, we'd be breaking // the contract anyway + // This allows the null check to be elided in the destructor if we + // manipulated the reference count in the same function. assume(!self._ptr.is_null()); &(**self._ptr) }