From a7b311ac614ea15f7261eb2ddca56072c18b3cba Mon Sep 17 00:00:00 2001 From: Erick Tryzelaar Date: Fri, 29 Nov 2013 21:26:03 -0800 Subject: [PATCH] extra: missed a couple `@` in json --- src/libextra/json.rs | 18 +++++++++--------- src/libextra/test.rs | 5 +++-- src/librustdoc/lib.rs | 9 ++++++--- src/libsyntax/parse/mod.rs | 2 +- 4 files changed, 19 insertions(+), 15 deletions(-) diff --git a/src/libextra/json.rs b/src/libextra/json.rs index 1b2165fb4cf8..30288a08c79d 100644 --- a/src/libextra/json.rs +++ b/src/libextra/json.rs @@ -464,7 +464,7 @@ impl Json{ pub fn to_pretty_str(&self) -> ~str { let mut s = MemWriter::new(); self.to_pretty_writer(&mut s as &mut io::Writer); - str::from_utf8(s.inner_ref().as_slice()) + str::from_utf8_owned(s.inner()) } } @@ -847,7 +847,7 @@ impl> Parser { /// Decodes a json value from an `&mut io::Reader` pub fn from_reader(rdr: &mut io::Reader) -> Result { - let s = str::from_utf8(rdr.read_to_end()); + let s = str::from_utf8_owned(rdr.read_to_end()); let mut parser = Parser::init(s.chars()); parser.parse() } @@ -1319,9 +1319,9 @@ impl ToJson for Option { impl to_str::ToStr for Json { /// Encodes a json value into a string fn to_str(&self) -> ~str { - let s = @mut MemWriter::new(); - self.to_writer(s as @mut io::Writer); - str::from_utf8(s.inner_ref().as_slice()) + let mut s = MemWriter::new(); + self.to_writer(&mut s as &mut io::Writer); + str::from_utf8_owned(s.inner()) } } @@ -1507,14 +1507,14 @@ mod tests { assert_eq!(a.clone(), from_str(a.to_pretty_str()).unwrap()); } - fn with_str_writer(f: |@mut io::Writer|) -> ~str { + fn with_str_writer(f: |&mut io::Writer|) -> ~str { use std::io::mem::MemWriter; use std::io::Decorator; use std::str; - let m = @mut MemWriter::new(); - f(m as @mut io::Writer); - str::from_utf8(*m.inner_ref()) + let mut m = MemWriter::new(); + f(&mut m as &mut io::Writer); + str::from_utf8_owned(m.inner()) } #[test] diff --git a/src/libextra/test.rs b/src/libextra/test.rs index ba9478e4448f..7d6fd81c6141 100644 --- a/src/libextra/test.rs +++ b/src/libextra/test.rs @@ -945,8 +945,9 @@ impl MetricMap { /// Load MetricDiff from a file. pub fn load(p: &Path) -> MetricMap { assert!(p.exists()); - let f = @mut File::open(p) as @mut io::Reader; - let mut decoder = json::Decoder::init(json::from_reader(f).unwrap()); + let mut f = File::open(p); + let value = json::from_reader(&mut f as &mut io::Reader).unwrap(); + let mut decoder = json::Decoder::init(value); MetricMap(Decodable::decode(&mut decoder)) } diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index 5edafa1b1f69..b2fb72d983b9 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -312,9 +312,12 @@ fn json_output(crate: clean::Crate, res: ~[plugins::PluginJson], dst: Path) { // FIXME #8335: yuck, Rust -> str -> JSON round trip! No way to .encode // straight to the Rust JSON representation. let crate_json_str = { - let w = @mut MemWriter::new(); - crate.encode(&mut json::Encoder::init(w as @mut io::Writer)); - str::from_utf8(*w.inner_ref()) + let mut w = MemWriter::new(); + { + let mut encoder = json::Encoder::init(&mut w as &mut io::Writer); + crate.encode(&mut encoder); + } + str::from_utf8_owned(w.inner()) }; let crate_json = match json::from_str(crate_json_str) { Ok(j) => j, diff --git a/src/libsyntax/parse/mod.rs b/src/libsyntax/parse/mod.rs index 988e9958c2b8..54a3dad94959 100644 --- a/src/libsyntax/parse/mod.rs +++ b/src/libsyntax/parse/mod.rs @@ -346,7 +346,7 @@ mod test { let mut writer = MemWriter::new(); let mut encoder = extra::json::Encoder::init(&mut writer as &mut io::Writer); val.encode(&mut encoder); - str::from_utf8(*writer.inner_ref()) + str::from_utf8_owned(writer.inner()) } // produce a codemap::span