user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Nested job objects are now supported in CI

Browse source 
Nested job objects aren't supported on Windows 7 but we've long since moved on from that.
This commit is contained in:
Chris Denton 2024-12-05 03:18:53 +00:00
parent 01442e70a7
commit a89f340efe
No known key found for this signature in database
GPG key ID: 713472F2F45627DE
1 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/bootstrap/src/utils/job.rs
View file

@ -87,15 +87,7 @@ mod for_windows {
);
assert!(r.is_ok(), "{}", io::Error::last_os_error());
// Assign our process to this job object. Note that if this fails, one very
// likely reason is that we are ourselves already in a job object! This can
// happen on the build bots that we've got for Windows, or if just anyone
// else is instrumenting the build. In this case we just bail out
// immediately and assume that they take care of it.
//
// Also note that nested jobs (why this might fail) are supported in recent
// versions of Windows, but the version of Windows that our bots are running
// at least don't support nested job objects.
// Assign our process to this job object.
let r = AssignProcessToJobObject(job, GetCurrentProcess());
if r.is_err() {
CloseHandle(job).ok();