From a907b7c51929eccd5af8774c60ac412772f2cacd Mon Sep 17 00:00:00 2001 From: Alessandro Decina Date: Mon, 8 Jul 2019 18:13:30 +1000 Subject: [PATCH] Normalize type parameters in create_mono_items_for_default_impls. Fixes http://github.com/rust-lang/rust/issues/58375 --- src/librustc_mir/monomorphize/collector.rs | 7 +++++- .../issue-58375-monomorphize-default-impls.rs | 23 +++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 src/test/run-pass/issue-58375-monomorphize-default-impls.rs diff --git a/src/librustc_mir/monomorphize/collector.rs b/src/librustc_mir/monomorphize/collector.rs index 6e9390f77508..acf438dc66bf 100644 --- a/src/librustc_mir/monomorphize/collector.rs +++ b/src/librustc_mir/monomorphize/collector.rs @@ -1166,8 +1166,13 @@ fn create_mono_items_for_default_impls<'tcx>( } }); + let param_env = ty::ParamEnv::reveal_all(); + let substs = tcx.normalize_erasing_regions( + param_env, + substs, + ); let instance = ty::Instance::resolve(tcx, - ty::ParamEnv::reveal_all(), + param_env, method.def_id, substs).unwrap(); diff --git a/src/test/run-pass/issue-58375-monomorphize-default-impls.rs b/src/test/run-pass/issue-58375-monomorphize-default-impls.rs new file mode 100644 index 000000000000..e4ae72927a4e --- /dev/null +++ b/src/test/run-pass/issue-58375-monomorphize-default-impls.rs @@ -0,0 +1,23 @@ +// Make sure that the mono-item collector does not crash when trying to +// instantiate a default impl for DecodeUtf16<::Item> +// See https://github.com/rust-lang/rust/issues/58375 +// compile-flags:-C link-dead-code + +#![crate_type = "rlib"] + +pub struct DecodeUtf16(I); + +pub trait Arbitrary { + fn arbitrary() {} +} + +pub trait A { + type Item; +} + +impl A for u8 { + type Item = char; +} + +impl Arbitrary for DecodeUtf16<::Item> { +} \ No newline at end of file