user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't complete already used derive attributes

Browse source
This commit is contained in:
Lukas Wirth 2021-06-16 19:27:06 +02:00
parent 8f936c5571
commit a92ed1eef4
1 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

40
crates/ide_completion/src/completions/attribute/derive.rs
View file

@ -31,6 +31,8 @@ pub(super) fn complete_derive(
let lookup = components.join(", ");
let label = components.iter().rev().join(", ");
(label, Some(lookup))
} else if existing_derives.contains(&derive) {
continue;
} else {
(derive, None)
};
@ -139,16 +141,15 @@ pub macro Ord {}
check(
r#"#[derive(serde::Serialize, PartialEq, $0)] struct Test;"#,
expect![[r#"
at PartialEq
at Default
at Eq
at Eq, PartialOrd, Ord
at Clone, Copy
at Debug
at Clone
at Hash
at PartialOrd
"#]],
at Default
at Eq
at Eq, PartialOrd, Ord
at Clone, Copy
at Debug
at Clone
at Hash
at PartialOrd
"#]],
)
}
@ -157,16 +158,15 @@ pub macro Ord {}
check(
r#"#[derive($0 serde::Serialize, PartialEq)] struct Test;"#,
expect![[r#"
at PartialEq
at Default
at Eq
at Eq, PartialOrd, Ord
at Clone, Copy
at Debug
at Clone
at Hash
at PartialOrd
"#]],
at Default
at Eq
at Eq, PartialOrd, Ord
at Clone, Copy
at Debug
at Clone
at Hash
at PartialOrd
"#]],
)
}
}