user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

std: Modernize the local_data api

Browse source 
This commit brings the local_data api up to modern rust standards with a few key
improvements:

* The `pop` and `set` methods have been combined into one method, `replace`

* The `get_mut` method has been removed. All interior mutability should be done
  through `RefCell`.

* All functionality is now exposed as a method on the keys themselves. Instead
  of importing std::local_data, you now use "key.replace()" and "key.get()".

* All closures have been removed in favor of RAII functionality. This means that
  get() and get_mut() no long require closures, but rather return
  Option<SmartPointer> where the smart pointer takes care of relinquishing the
  borrow and also implements the necessary Deref traits

* The modify() function was removed to cut the local_data interface down to its
  bare essentials (similarly to how RefCell removed set/get).

[breaking-change]
This commit is contained in:
Alex Crichton 2014-04-28 20:36:08 -07:00
parent ef6daf9935
commit ab92ea526d
23 changed files with 444 additions and 661 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/test/compile-fail/core-tls-store-pointer.rs
View file

@ -10,8 +10,6 @@
// Testing that we can't store a reference it task-local storage
use std::local_data;
local_data_key!(key: @&int)
//~^ ERROR missing lifetime specifier

4
src/test/compile-fail/macro-local-data-key-priv.rs
View file

@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.
use std::local_data;
// check that the local data keys are private by default.
mod bar {
@ -17,6 +15,6 @@ mod bar {
}
fn main() {
local_data::set(bar::baz, -10.0);
bar::baz.replace(Some(-10.0));
//~^ ERROR static `baz` is private
}