user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #697 from tgross35/f16-asm

Browse source 
Resolve FIXMEs related to `f16` assembly
This commit is contained in:
Trevor Gross 2024-09-28 18:04:31 -04:00 • committed by GitHub
commit ac07aeb2db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

7
library/compiler-builtins/testcrate/benches/float_extend.rs
View file

@ -15,11 +15,10 @@ float_bench! {
sys_available: not(feature = "no-sys-f16"),
asm: [
#[cfg(target_arch = "aarch64")] {
// FIXME(f16_f128): remove `to_bits()` after f16 asm support (rust-lang/rust/#116909)
let ret: f32;
asm!(
"fcvt {ret:s}, {a:h}",
a = in(vreg) a.to_bits(),
a = in(vreg) a,
ret = lateout(vreg) ret,
options(nomem, nostack, pure),
);
@ -96,9 +95,7 @@ pub fn float_extend() {
extend_f16_f32(&mut criterion);
#[cfg(f128_enabled)]
{
extend_f16_f128(&mut criterion);
}
extend_f16_f128(&mut criterion);
}
extend_f32_f64(&mut criterion);

14
library/compiler-builtins/testcrate/benches/float_trunc.rs
View file

@ -14,8 +14,7 @@ float_bench! {
sys_available: not(feature = "no-sys-f16"),
asm: [
#[cfg(target_arch = "aarch64")] {
// FIXME(f16_f128): remove `from_bits()` after f16 asm support (rust-lang/rust/#116909)
let ret: u16;
let ret: f16;
asm!(
"fcvt {ret:h}, {a:s}",
a = in(vreg) a,
@ -23,7 +22,7 @@ float_bench! {
options(nomem, nostack, pure),
);
f16::from_bits(ret)
ret
};
],
}
@ -37,8 +36,7 @@ float_bench! {
sys_available: not(feature = "no-sys-f16"),
asm: [
#[cfg(target_arch = "aarch64")] {
// FIXME(f16_f128): remove `from_bits()` after f16 asm support (rust-lang/rust/#116909)
let ret: u16;
let ret: f16;
asm!(
"fcvt {ret:h}, {a:d}",
a = in(vreg) a,
@ -46,7 +44,7 @@ float_bench! {
options(nomem, nostack, pure),
);
f16::from_bits(ret)
ret
};
],
}
@ -138,9 +136,7 @@ pub fn float_trunc() {
// FIXME(#655): `f16` tests disabled until we can bootstrap symbols
#[cfg(f16_enabled)]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
{
trunc_f128_f16(&mut criterion);
}
trunc_f128_f16(&mut criterion);
trunc_f128_f32(&mut criterion);
trunc_f128_f64(&mut criterion);