From adca15a151422a72d69c39ade946f36a2ff072a6 Mon Sep 17 00:00:00 2001 From: Niko Matsakis Date: Mon, 29 Dec 2014 11:00:56 -0500 Subject: [PATCH] Add a FIXME relating to using `ast::Name` --- src/librustc/middle/def.rs | 1 + src/librustc_typeck/astconv.rs | 3 +-- src/libsyntax/ast.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/librustc/middle/def.rs b/src/librustc/middle/def.rs index 59fd41b5d29e..ff1ee3949662 100644 --- a/src/librustc/middle/def.rs +++ b/src/librustc/middle/def.rs @@ -36,6 +36,7 @@ pub enum Def { // A partially resolved path to an associated type `T::U` where `T` is a concrete // type (indicated by the DefId) which implements a trait which has an associated // type `U` (indicated by the Ident). + // FIXME(#20301) -- should use Name DefAssociatedPath(TyParamProvenance, ast::Ident), DefTrait(ast::DefId), DefPrimTy(ast::PrimTy), diff --git a/src/librustc_typeck/astconv.rs b/src/librustc_typeck/astconv.rs index 477171051640..480bba16e634 100644 --- a/src/librustc_typeck/astconv.rs +++ b/src/librustc_typeck/astconv.rs @@ -992,7 +992,7 @@ fn qpath_to_ty<'tcx,AC,RS>(this: &AC, return this.projected_ty(ast_ty.span, trait_ref, - qpath.item_name.name); // TODO change qpath to use name + qpath.item_name.name); } // Parses the programmer's textual representation of a type into our @@ -1155,7 +1155,6 @@ pub fn ast_ty_to_ty<'tcx, AC: AstConv<'tcx>, RS: RegionScope>( this.tcx().types.err } def::DefAssociatedPath(provenance, assoc_ident) => { - // TODO update DefAssociatedPath to use name associated_path_def_to_ty(this, ast_ty, provenance, assoc_ident.name) } _ => { diff --git a/src/libsyntax/ast.rs b/src/libsyntax/ast.rs index f253943943dc..12432c8c78f2 100644 --- a/src/libsyntax/ast.rs +++ b/src/libsyntax/ast.rs @@ -764,7 +764,7 @@ pub enum Expr_ { pub struct QPath { pub self_type: P, pub trait_ref: P, - pub item_name: Ident, + pub item_name: Ident, // FIXME(#20301) -- should use Name } #[deriving(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Show, Copy)]