user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not allow defaults for Mode and Config

Browse source 
They do not have sensible defaults, and it is crucial that we get them
right.
This commit is contained in:
Jieyou Xu 2025-07-12 15:59:16 +08:00
parent 832b6273bd
commit b4dfd51bac
No known key found for this signature in database
GPG key ID: 045B995028EA6AFC
1 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/tools/compiletest/src/common.rs
View file

@ -34,12 +34,6 @@ string_enum! {
}
}
impl Default for Mode {
fn default() -> Self {
Mode::Ui
}
}
impl Mode {
pub fn aux_dir_disambiguator(self) -> &'static str {
// Pretty-printing tests could run concurrently, and if they do,
@ -151,7 +145,7 @@ pub enum Sanitizer {
///
/// FIXME: audit these options to make sure we are not hashing less than necessary for build stamp
/// (for changed test detection).
#[derive(Debug, Default, Clone)]
#[derive(Debug, Clone)]
pub struct Config {
/// Some test [`Mode`]s support [snapshot testing], where a *reference snapshot* of outputs (of
/// `stdout`, `stderr`, or other form of artifacts) can be compared to the *actual output*.