user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

librustc: Add a lint mode for unnecessary copy and remove a bunch of them.

Browse source
This commit is contained in:
Patrick Walton 2013-06-27 17:41:35 -07:00
parent 8c082658be
commit b4e674f6e6
59 changed files with 256 additions and 235 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/librustdoc/fold.rs
View file

@ -33,18 +33,18 @@ impl<T:Clone> Clone for Fold<T> {
fn clone(&self) -> Fold<T> {
Fold {
ctxt: self.ctxt.clone(),
fold_doc: copy self.fold_doc,
fold_crate: copy self.fold_crate,
fold_item: copy self.fold_item,
fold_mod: copy self.fold_mod,
fold_nmod: copy self.fold_nmod,
fold_fn: copy self.fold_fn,
fold_const: copy self.fold_const,
fold_enum: copy self.fold_enum,
fold_trait: copy self.fold_trait,
fold_impl: copy self.fold_impl,
fold_type: copy self.fold_type,
fold_struct: copy self.fold_struct
fold_doc: self.fold_doc,
fold_crate: self.fold_crate,
fold_item: self.fold_item,
fold_mod: self.fold_mod,
fold_nmod: self.fold_nmod,
fold_fn: self.fold_fn,
fold_const: self.fold_const,
fold_enum: self.fold_enum,
fold_trait: self.fold_trait,
fold_impl: self.fold_impl,
fold_type: self.fold_type,
fold_struct: self.fold_struct
}
}
}

21
src/librustdoc/text_pass.rs
View file

@ -63,9 +63,9 @@ fn fold_item(
let doc = fold::default_seq_fold_item(fold, doc);
doc::ItemDoc {
brief: maybe_apply_op(copy fold.ctxt, &doc.brief),
desc: maybe_apply_op(copy fold.ctxt, &doc.desc),
sections: apply_to_sections(copy fold.ctxt, copy doc.sections),
brief: maybe_apply_op(fold.ctxt, &doc.brief),
desc: maybe_apply_op(fold.ctxt, &doc.desc),
sections: apply_to_sections(fold.ctxt, copy doc.sections),
.. doc
}
}
@ -84,12 +84,12 @@ fn fold_enum(
fold: &fold::Fold<NominalOp<Op>>,
doc: doc::EnumDoc) -> doc::EnumDoc {
let doc = fold::default_seq_fold_enum(fold, doc);
let fold_copy = copy *fold;
let fold_copy = *fold;
doc::EnumDoc {
variants: do doc.variants.map |variant| {
doc::VariantDoc {
desc: maybe_apply_op(copy fold_copy.ctxt, &variant.desc),
desc: maybe_apply_op(fold_copy.ctxt, &variant.desc),
.. copy *variant
}
},
@ -104,7 +104,7 @@ fn fold_trait(
let doc = fold::default_seq_fold_trait(fold, doc);
doc::TraitDoc {
methods: apply_to_methods(copy fold.ctxt, copy doc.methods),
methods: apply_to_methods(fold.ctxt, copy doc.methods),
.. doc
}
}
@ -113,12 +113,11 @@ fn apply_to_methods(
op: NominalOp<Op>,
docs: ~[doc::MethodDoc]
) -> ~[doc::MethodDoc] {
let op = copy op;
do docs.map |doc| {
doc::MethodDoc {
brief: maybe_apply_op(copy op, &doc.brief),
desc: maybe_apply_op(copy op, &doc.desc),
sections: apply_to_sections(copy op, copy doc.sections),
brief: maybe_apply_op(op, &doc.brief),
desc: maybe_apply_op(op, &doc.desc),
sections: apply_to_sections(op, copy doc.sections),
.. copy *doc
}
}
@ -131,7 +130,7 @@ fn fold_impl(
let doc = fold::default_seq_fold_impl(fold, doc);
doc::ImplDoc {
methods: apply_to_methods(copy fold.ctxt, copy doc.methods),
methods: apply_to_methods(fold.ctxt, copy doc.methods),
.. doc
}
}