From b5fef37d23f4e4471caea5508ab18da20522e51f Mon Sep 17 00:00:00 2001 From: Rich Kadel Date: Tue, 24 Nov 2020 18:34:10 -0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Wesley Wiser --- compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs | 2 +- src/test/run-make-fulldeps/coverage-llvmir-base/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs b/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs index d3de960fbec8..51baa2aafb7d 100644 --- a/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs +++ b/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs @@ -169,7 +169,7 @@ impl CoverageMapGenerator { ); // Create the coverage data header (Note, fields 0 and 2 are now always zero, - // as of `llvm::coverage::CovMapVersion::Version4`. + // as of `llvm::coverage::CovMapVersion::Version4`.) let zero_was_n_records_val = cx.const_u32(0); let filenames_size_val = cx.const_u32(filenames_size as u32); let zero_was_coverage_size_val = cx.const_u32(0); diff --git a/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile b/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile index 2b803b95053a..219ba15ad116 100644 --- a/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile +++ b/src/test/run-make-fulldeps/coverage-llvmir-base/Makefile @@ -56,7 +56,7 @@ else -DINSTR_PROF_ORDERFILE='$(DATA_SECTION_PREFIX)__llvm_orderfile' endif -ifeq ($(LLVM_VERSION_11_PLUS),false) +ifeq ($(LLVM_VERSION_11_PLUS),true) all: test_llvm_ir else $(info Rust option `-Z instrument-coverage` requires LLVM 11 or higher. Test skipped.)