Address code reviews

This commit is contained in:
Yuki Okushi 2020-07-05 03:40:59 +09:00
parent dcbe85abad
commit b93ecc1dac
No known key found for this signature in database
GPG key ID: B0986C85C0E2DAA1
4 changed files with 43 additions and 21 deletions

View file

@ -6,8 +6,8 @@ LL | match 0usize {
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `usize`
= note: for `usize` and `isize`, no assumptions about the maximum value are permitted
= note: to exhaustively match on either pointer-size integer type, wildcards must be used
= note: `usize` does not have a fixed maximum value, so a wildcard `_` is necessary to match exhaustively
= help: add `#![feature(precise_pointer_size_matching)]` to the crate attributes to enable precise `usize` matching
error[E0004]: non-exhaustive patterns: `_` not covered
--> $DIR/feature-gate-precise_pointer_size_matching.rs:10:11
@ -17,8 +17,8 @@ LL | match 0isize {
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `isize`
= note: for `usize` and `isize`, no assumptions about the maximum value are permitted
= note: to exhaustively match on either pointer-size integer type, wildcards must be used
= note: `isize` does not have a fixed maximum value, so a wildcard `_` is necessary to match exhaustively
= help: add `#![feature(precise_pointer_size_matching)]` to the crate attributes to enable precise `isize` matching
error: aborting due to 2 previous errors

View file

@ -5,8 +5,7 @@ fn main() {
//~^ ERROR non-exhaustive patterns
//~| NOTE pattern `_` not covered
//~| NOTE the matched value is of type `usize`
//~| NOTE for `usize` and `isize`, no assumptions about the maximum value are permitted
//~| NOTE to exhaustively match on either pointer-size integer type, wildcards must be used
//~| NOTE `usize` does not have a fixed maximum value
0 ..= usize::MAX => {}
}
@ -14,8 +13,11 @@ fn main() {
//~^ ERROR non-exhaustive patterns
//~| NOTE pattern `_` not covered
//~| NOTE the matched value is of type `isize`
//~| NOTE for `usize` and `isize`, no assumptions about the maximum value are permitted
//~| NOTE to exhaustively match on either pointer-size integer type, wildcards must be used
//~| NOTE `isize` does not have a fixed maximum value
isize::MIN ..= isize::MAX => {}
}
match 7usize {}
//~^ ERROR non-exhaustive patterns
//~| NOTE the matched value is of type `usize`
}

View file

@ -6,20 +6,29 @@ LL | match 0usize {
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `usize`
= note: for `usize` and `isize`, no assumptions about the maximum value are permitted
= note: to exhaustively match on either pointer-size integer type, wildcards must be used
= note: `usize` does not have a fixed maximum value, so a wildcard `_` is necessary to match exhaustively
= help: add `#![feature(precise_pointer_size_matching)]` to the crate attributes to enable precise `usize` matching
error[E0004]: non-exhaustive patterns: `_` not covered
--> $DIR/non-exhaustive-pattern-pointer-size-int.rs:13:11
--> $DIR/non-exhaustive-pattern-pointer-size-int.rs:12:11
|
LL | match 0isize {
| ^^^^^^ pattern `_` not covered
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `isize`
= note: for `usize` and `isize`, no assumptions about the maximum value are permitted
= note: to exhaustively match on either pointer-size integer type, wildcards must be used
= note: `isize` does not have a fixed maximum value, so a wildcard `_` is necessary to match exhaustively
= help: add `#![feature(precise_pointer_size_matching)]` to the crate attributes to enable precise `isize` matching
error: aborting due to 2 previous errors
error[E0004]: non-exhaustive patterns: type `usize` is non-empty
--> $DIR/non-exhaustive-pattern-pointer-size-int.rs:20:11
|
LL | match 7usize {}
| ^^^^^^
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `usize`
error: aborting due to 3 previous errors
For more information about this error, try `rustc --explain E0004`.