From bc93f7052e4a76d62e2aa5f11649e662cb46c7ce Mon Sep 17 00:00:00 2001
From: Eduardo Broto <ebroto@tutanota.com>
Date: Mon, 18 May 2020 20:56:33 +0200
Subject: [PATCH] Add test for cargo_common_metadata

Fix missing `authors` entry in the provided example
---
 clippy_lints/src/cargo_common_metadata.rs      |  1 +
 .../cargo_common_metadata/fail/Cargo.toml      |  3 +++
 .../cargo_common_metadata/fail/src/main.rs     |  3 +++
 .../cargo_common_metadata/fail/src/main.stderr | 18 ++++++++++++++++++
 .../cargo_common_metadata/pass/Cargo.toml      | 10 ++++++++++
 .../cargo_common_metadata/pass/src/main.rs     |  3 +++
 6 files changed, 38 insertions(+)
 create mode 100644 tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml
 create mode 100644 tests/ui-cargo/cargo_common_metadata/fail/src/main.rs
 create mode 100644 tests/ui-cargo/cargo_common_metadata/fail/src/main.stderr
 create mode 100644 tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
 create mode 100644 tests/ui-cargo/cargo_common_metadata/pass/src/main.rs

diff --git a/clippy_lints/src/cargo_common_metadata.rs b/clippy_lints/src/cargo_common_metadata.rs
index 782da249808d..16b46423c8f0 100644
--- a/clippy_lints/src/cargo_common_metadata.rs
+++ b/clippy_lints/src/cargo_common_metadata.rs
@@ -23,6 +23,7 @@ declare_clippy_lint! {
     /// [package]
     /// name = "clippy"
     /// version = "0.0.212"
+    /// authors = ["Someone <someone@rust-lang.org>"]
     /// description = "A bunch of helpful lints to avoid common pitfalls in Rust"
     /// repository = "https://github.com/rust-lang/rust-clippy"
     /// readme = "README.md"
diff --git a/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml b/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml
new file mode 100644
index 000000000000..8346bf057783
--- /dev/null
+++ b/tests/ui-cargo/cargo_common_metadata/fail/Cargo.toml
@@ -0,0 +1,3 @@
+[package]
+name = "cargo_common_metadata"
+version = "0.1.0"
diff --git a/tests/ui-cargo/cargo_common_metadata/fail/src/main.rs b/tests/ui-cargo/cargo_common_metadata/fail/src/main.rs
new file mode 100644
index 000000000000..c67166fc4b00
--- /dev/null
+++ b/tests/ui-cargo/cargo_common_metadata/fail/src/main.rs
@@ -0,0 +1,3 @@
+#![warn(clippy::cargo_common_metadata)]
+
+fn main() {}
diff --git a/tests/ui-cargo/cargo_common_metadata/fail/src/main.stderr b/tests/ui-cargo/cargo_common_metadata/fail/src/main.stderr
new file mode 100644
index 000000000000..c8ae6c820df9
--- /dev/null
+++ b/tests/ui-cargo/cargo_common_metadata/fail/src/main.stderr
@@ -0,0 +1,18 @@
+error: package `cargo_common_metadata` is missing `package.authors` metadata
+   |
+   = note: `-D clippy::cargo-common-metadata` implied by `-D warnings`
+
+error: package `cargo_common_metadata` is missing `package.description` metadata
+
+error: package `cargo_common_metadata` is missing `either package.license or package.license_file` metadata
+
+error: package `cargo_common_metadata` is missing `package.repository` metadata
+
+error: package `cargo_common_metadata` is missing `package.readme` metadata
+
+error: package `cargo_common_metadata` is missing `package.keywords` metadata
+
+error: package `cargo_common_metadata` is missing `package.categories` metadata
+
+error: aborting due to 7 previous errors
+
diff --git a/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml b/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
new file mode 100644
index 000000000000..f99c126fabf6
--- /dev/null
+++ b/tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
@@ -0,0 +1,10 @@
+[package]
+name = "cargo_common_metadata"
+version = "0.1.0"
+authors = ["Random person from the Internet <someone@someplace.org>"]
+description = "A test package for the cargo_common_metadata lint"
+repository = "https://github.com/someone/cargo_common_metadata"
+readme = "README.md"
+license = "MIT OR Apache-2.0"
+keywords = ["metadata", "lint", "clippy"]
+categories = ["development-tools::testing"]
diff --git a/tests/ui-cargo/cargo_common_metadata/pass/src/main.rs b/tests/ui-cargo/cargo_common_metadata/pass/src/main.rs
new file mode 100644
index 000000000000..c67166fc4b00
--- /dev/null
+++ b/tests/ui-cargo/cargo_common_metadata/pass/src/main.rs
@@ -0,0 +1,3 @@
+#![warn(clippy::cargo_common_metadata)]
+
+fn main() {}