use the closure def-id in returns, but closure-base def-id in locals

Using the `closure_base_def_id` indiscriminantely, as we were doing
before, winds up "going wrong" if the closure type includes the `impl
Trait` from the parent. The problem arises because the return value
for closures is inferred and meant to treat the return
type *opaquely*, so we don't want to be "desugaring" it into the
underlying type.
This commit is contained in:
Niko Matsakis 2018-09-26 16:37:31 -04:00
parent c7df1f530b
commit bcfdfe4e50
3 changed files with 37 additions and 5 deletions

View file

@ -0,0 +1,14 @@
#![feature(nll)]
// Regression test for #54593: the MIR type checker was going wrong
// when a closure returns the `impl Copy` from its parent fn. It was
// (incorrectly) replacing the `impl Copy` in its return type with the
// hidden type (`()`) but that type resulted from a recursive call to
// `foo` and hence is treated opaquely within the closure body. This
// resulted in a failed subtype relationship.
//
// run-pass
fn foo() -> impl Copy { || foo(); }
fn bar() -> impl Copy { || bar(); }
fn main() { }